From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757398Ab0BKXn1 (ORCPT ); Thu, 11 Feb 2010 18:43:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54277 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757297Ab0BKXn0 (ORCPT ); Thu, 11 Feb 2010 18:43:26 -0500 Date: Thu, 11 Feb 2010 15:42:21 -0800 From: Greg KH To: "Eric W. Biederman" Cc: =?iso-8859-1?Q?Am=E9rico?= Wang , "Tejun Heo Neil Brown" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] sysfs: Use sysfs_attr_init and sysfs_bin_attr_init on dynamic attributes Message-ID: <20100211234221.GA10498@suse.de> References: <4B728CFE.40208@kernel.org> <20100210230544.GA678@suse.de> <4B73671E.2050105@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2010 at 03:23:05PM -0800, Eric W. Biederman wrote: > > These are the non-static sysfs attributes that exist on > my test machine. Fix them to use sysfs_attr_init or > sysfs_bin_attr_init as appropriate. It simply requires > making a sysfs attribute present to see this. So this > is a little bit tedious but otherwise not too bad. Can we document this in the sysfs_attr_init kerneldoc documentation that you add for this new function? thanks, greg k-h