From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
lkml <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH] perf_events: Fix FORK events
Date: Sat, 13 Feb 2010 11:53:00 -0200 [thread overview]
Message-ID: <20100213135300.GB2602@ghostprotocols.net> (raw)
In-Reply-To: <1265644666.11509.5.camel@laptop>
Em Mon, Feb 08, 2010 at 04:57:46PM +0100, Peter Zijlstra escreveu:
> On Mon, 2010-02-08 at 08:44 +0100, Ingo Molnar wrote:
> >
> > > We could of course just slam the commit in and not worry about it, but
> > > that just doesn't feel right.
> >
> > Would be nice to figure it out ...
>
> OK, so it is real simple, patch 22e19085 ("perf: Honour event state for
> aux stream data") drops all events for !ACTIVE and newly inherited child
> counters are INACTIVE.
>
> So we can either go with the original patch and send the FORK events to
> the parent because that's always ACTIVE (already true for COMM and
> MMAP), or weaken the state test to < INACTIVE, which would also satisfy
> Anton's case because PERF_EVENT_IOC_DISABLE sets events to OFF.
I saw the missing forks on another testcase and after applying the
original patch I got them, I guess we should apply that one to have
2.6.33 good in this regard, if still possible to get this in.
- Arnaldo
prev parent reply other threads:[~2010-02-13 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 15:37 [RFC][PATCH] perf_events: Fix FORK events Peter Zijlstra
2010-02-08 7:44 ` Ingo Molnar
2010-02-08 15:57 ` Peter Zijlstra
2010-02-13 13:53 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213135300.GB2602@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox