From: Ingo Molnar <mingo@elte.hu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
dipankar@in.ibm.com, akpm@linux-foundation.org,
mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH tip/core/rcu 05/13] net: add checking to rcu_dereference() primitives
Date: Sun, 14 Feb 2010 09:23:14 +0100 [thread overview]
Message-ID: <20100214082314.GA12658@elte.hu> (raw)
In-Reply-To: <1265948152.2891.25.camel@edumazet-laptop>
* Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le jeudi 11 f??vrier 2010 ?? 16:00 -0800, Paul E. McKenney a ??crit :
> > Update rcu_dereference() primitives to use new lockdep-based checking.
> > The rcu_dereference() in __in6_dev_get() may be protected either by
> > rcu_read_lock() or RTNL, per Eric Dumazet. The rcu_dereference()
> > in __sk_free() is protected by the fact that it is never reached if an
> > update could change it. Check for this by using rcu_dereference_check()
> > to verify that the struct sock's ->sk_wmem_alloc counter is zero.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> CC to netdev and David Miller, network maintainer.
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Thanks Paul, great work !
Dave, does this look good to you too? Cannot pick up the rest of the patchset
without these checks/annotations into the RCU tree as there's too many
warnings triggering in the networking code. So it's an all-or-nothing
patchset in that regard.
Thanks,
Ingo
next prev parent reply other threads:[~2010-02-14 8:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 0:00 [PATCH tip/core/rcu 0/13] rcu: add lockdep checking, doc update, dyntick GP acceleration Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 01/13] rcu: introduce lockdep-based checking to RCU read-side primitives Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 02/13] rcu: add lockdep-enabled variants of rcu_dereference() Paul E. McKenney
2010-02-12 4:13 ` Eric Dumazet
2010-02-12 0:00 ` [PATCH tip/core/rcu 03/13] rcu: integrate rcu_dereference_check() message into lockdep Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 04/13] rcu: disable lockdep checking in RCU list-traversal primitives Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 05/13] net: add checking to rcu_dereference() primitives Paul E. McKenney
2010-02-12 4:15 ` Eric Dumazet
2010-02-14 8:23 ` Ingo Molnar [this message]
2010-02-15 7:18 ` David Miller
2010-02-14 8:34 ` Michał Mirosław
2010-02-14 8:50 ` Eric Dumazet
2010-02-12 0:00 ` [PATCH tip/core/rcu 06/13] sched: use lockdep-based checking on rcu_dereference() Paul E. McKenney
2010-02-14 10:12 ` Peter Zijlstra
2010-02-14 17:48 ` Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 07/13] vfs: apply lockdep-based checking to rcu_dereference() uses Paul E. McKenney
2010-02-14 10:12 ` Peter Zijlstra
2010-02-14 17:37 ` Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 08/13] radix-tree: disable RCU lockdep checking in radix tree Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 09/13] idr: apply lockdep-based diagnostics to rcu_dereference() uses Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 10/13] security: apply lockdep-based checking " Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 11/13] rcu: documentation update for CONFIG_PROVE_RCU Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 12/13] rcu: fix citation of Mathieu's dissertation Paul E. McKenney
2010-02-12 0:00 ` [PATCH tip/core/rcu 13/13] rcu: accelerate grace period if last non-dynticked CPU Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100214082314.GA12658@elte.hu \
--to=mingo@elte.hu \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox