From: Greg KH <gregkh@suse.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-kernel@vger.kernel.org, jirislaby@gmail.com,
devel@driverdev.osuosl.org, Phil Hannent <phil@hannent.co.uk>,
mwilder@cs.nmsu.edu, Dmitry Torokhov <dtor@mail.ru>
Subject: Re: [PATCH] staging: mimio, add extra sync to down-up input events
Date: Mon, 15 Feb 2010 07:41:58 -0800 [thread overview]
Message-ID: <20100215154158.GA22102@suse.de> (raw)
In-Reply-To: <1266179821-900-1-git-send-email-jslaby@suse.cz>
On Sun, Feb 14, 2010 at 09:37:01PM +0100, Jiri Slaby wrote:
> Userspace is allowed to coalesce events between SYNCs. And since the code
> emits UP right after DOWN for the same key, it may be missed
> (up+down=nothing). Add an extra sync in between UP and DOWN events to disable
> the coalesce.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: devel@driverdev.osuosl.org
> Cc: Phil Hannent <phil@hannent.co.uk>
> Cc: <mwilder@cs.nmsu.edu>
> Cc: Dmitry Torokhov <dtor@mail.ru>
> ---
> drivers/staging/mimio/mimio.c | 6 ++++++
Heh, I just deleted this driver from the staging tree, and it's gone in
linux-next, as the company now has a libusb version that works
cross-platform without any kernel changes needed.
So thanks for the patch, but it is no longer needed :)
greg k-h
prev parent reply other threads:[~2010-02-15 15:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 20:37 [PATCH] staging: mimio, add extra sync to down-up input events Jiri Slaby
2010-02-15 15:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100215154158.GA22102@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=dtor@mail.ru \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mwilder@cs.nmsu.edu \
--cc=phil@hannent.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox