From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: david-b@pacbell.net, gregkh@suse.de, tilman@imap.cc,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net-next 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level>
Date: Tue, 16 Feb 2010 23:37:14 -0800 (PST) [thread overview]
Message-ID: <20100216.233714.39181977.davem@davemloft.net> (raw)
In-Reply-To: <48cb1d6445dceaa7043d1039ca775a8961020d88.1266221693.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 15 Feb 2010 00:25:11 -0800
> These macros are too similar to the dev_<level> equivalents
> but take a usbnet * argument. Convert them to the recently
> introduced netdev_<level> macros and remove the old macros.
>
> The old macros had "\n" appended to the format string.
> Add the "\n" to the converted uses.
>
> Some existing uses of the dev<foo> macros in cdc_eem.c
> probably mistakenly had trailing "\n". No "\n" added there.
>
> Fix net1080 this/other log message inversion.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
next prev parent reply other threads:[~2010-02-17 7:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 1:43 [PATCH] usbnet: convert dev(dbg|err|warn|info) macros to usbnet_(dbg|err|warn|info) Joe Perches
2010-02-10 5:53 ` David Brownell
2010-02-10 6:16 ` Joe Perches
2010-02-10 6:56 ` David Brownell
2010-02-12 20:38 ` David Miller
2010-02-14 23:01 ` [net-next PATCH 0/2] usbnet: convert dev(dbg|err|warn|info) macros to netdev_<> Joe Perches
2010-02-14 23:01 ` [PATCH 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level> Joe Perches
2010-02-15 0:17 ` Tilman Schmidt
2010-02-15 0:54 ` Joe Perches
2010-02-15 3:09 ` David Brownell
2010-02-14 23:01 ` [PATCH 2/2] drivers/net/usb: Use netif_<level> logging facilities Joe Perches
2010-02-15 8:25 ` [PATCH V2 net-next 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level> Joe Perches
2010-02-17 7:37 ` David Miller [this message]
2010-02-17 8:04 ` David Miller
2010-02-17 20:30 ` [PATCH V3 net-next 0/2] usbnet: Use (netdev|netif)_<level> macros Joe Perches
2010-02-17 20:30 ` [PATCH V3 net-next 1/2] usbnet: Convert dev(dbg|err|warn|info) macros to netdev_<level> Joe Perches
2010-02-17 20:30 ` [PATCH V3 net-next 2/2] drivers/net/usb: Use netif_<level> logging facilities Joe Perches
2010-02-17 21:38 ` [PATCH V3 net-next 0/2] usbnet: Use (netdev|netif)_<level> macros David Miller
2010-02-17 21:44 ` Joe Perches
2010-02-17 21:54 ` David Miller
2010-02-15 8:25 ` [PATCH V2 net-next 2/2] drivers/net/usb: Use netif_<level> logging facilities Joe Perches
2010-02-17 7:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216.233714.39181977.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).