From: Oleg Nesterov <oleg@redhat.com>
To: Andi Kleen <andi@firstfloor.org>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Roland McGrath <roland@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: x86: get rid of the insane TIF_ABI_PENDING bit
Date: Tue, 16 Feb 2010 11:19:03 +0100 [thread overview]
Message-ID: <20100216101903.GA1057@redhat.com> (raw)
In-Reply-To: <4B79B202.5090006@zytor.com>
On 02/15, H. Peter Anvin wrote:
>
> On 02/15/2010 11:41 AM, Roland McGrath wrote:
> > It affects whatever uses is_compat_task(), but I can't see anything
> > where that matters except inside some particular syscall or for
> > syscall restart after signals.
>
> FWIW, the origin of this is checkin
> 4d9bc79cd28b779610d9590b3a96a28a0f64a25a (2.6.18-rc1), which somewhat
> unhelpfully states "Make sure is_compat_task works early". It doesn't
> specify what the failure is if is_compat_task doesn't work early.
Perhaps Andi could explain us why this is needed,
> On
> the other hand, it sure as heck seems better to set it and not need it
> than the other way around.
Agreed, but otoh it is always good to understand the code. If we
really have a reason for TS_COMPAT, a small comment can help other
readers.
Oleg.
next prev parent reply other threads:[~2010-02-16 10:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 16:17 x86: get rid of the insane TIF_ABI_PENDING bit Oleg Nesterov
2010-02-15 16:23 ` H. Peter Anvin
2010-02-15 16:50 ` Oleg Nesterov
2010-02-15 18:06 ` H. Peter Anvin
2010-02-15 18:52 ` Oleg Nesterov
2010-02-15 19:07 ` H. Peter Anvin
2010-02-15 19:10 ` H. Peter Anvin
2010-02-15 19:41 ` Roland McGrath
2010-02-15 20:07 ` H. Peter Anvin
2010-02-15 21:14 ` Roland McGrath
2010-02-15 20:43 ` H. Peter Anvin
2010-02-15 21:05 ` Roland McGrath
2010-02-16 10:19 ` Oleg Nesterov [this message]
2010-02-16 10:23 ` Andi Kleen
2010-02-16 14:01 ` [PATCH 0/3] Was: " Oleg Nesterov
2010-02-16 14:02 ` [PATCH 1/3] x86: set_personality_ia32() misses force_personality32 Oleg Nesterov
2010-02-16 23:27 ` [tip:x86/urgent] " tip-bot for Oleg Nesterov
2010-02-16 14:02 ` [PATCH 2/3] x86: set_personality_ia32() abuses TS_COMPAT Oleg Nesterov
2010-02-16 15:40 ` Linus Torvalds
2010-02-16 17:16 ` Oleg Nesterov
2010-02-16 17:38 ` H. Peter Anvin
2010-02-16 17:44 ` Oleg Nesterov
2010-02-16 17:51 ` H. Peter Anvin
2010-02-17 15:40 ` Oleg Nesterov
2010-02-16 18:43 ` Linus Torvalds
2010-02-16 14:03 ` [PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32 Oleg Nesterov
2010-02-16 14:24 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216101903.GA1057@redhat.com \
--to=oleg@redhat.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).