From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Roland McGrath <roland@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] Was: x86: get rid of the insane TIF_ABI_PENDING bit
Date: Tue, 16 Feb 2010 15:01:26 +0100 [thread overview]
Message-ID: <20100216140126.GA16448@redhat.com> (raw)
In-Reply-To: <20100216102332.GL21783@one.firstfloor.org>
On 02/16, Andi Kleen wrote:
>
> On Tue, Feb 16, 2010 at 11:19:03AM +0100, Oleg Nesterov wrote:
> >
> > Agreed, but otoh it is always good to understand the code. If we
> > really have a reason for TS_COMPAT, a small comment can help other
> > readers.
>
> My memory is somewhat fuzzy on this one, but I think it was related
> to VMA placement (probably for stack randomization or something like that)
> This happens before the first call. I might be wrong on that.
Afaics we never check TS_COMPAT/is_compat_task for this...
> There might also have been other is_compat_task checks in the exec init
> path, so partly it was defensive programming.
Understand, but it looks so confusing...
OK. Please feel free to ignore, but I am sending the trivial, but only
compile-tested patches. My main motivation is to simplify the reading
and understanding of this code.
The first patch looks like an "obvious" bugfix for 2.6.33 though, but
still untested.
Oleg.
next prev parent reply other threads:[~2010-02-16 14:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 16:17 x86: get rid of the insane TIF_ABI_PENDING bit Oleg Nesterov
2010-02-15 16:23 ` H. Peter Anvin
2010-02-15 16:50 ` Oleg Nesterov
2010-02-15 18:06 ` H. Peter Anvin
2010-02-15 18:52 ` Oleg Nesterov
2010-02-15 19:07 ` H. Peter Anvin
2010-02-15 19:10 ` H. Peter Anvin
2010-02-15 19:41 ` Roland McGrath
2010-02-15 20:07 ` H. Peter Anvin
2010-02-15 21:14 ` Roland McGrath
2010-02-15 20:43 ` H. Peter Anvin
2010-02-15 21:05 ` Roland McGrath
2010-02-16 10:19 ` Oleg Nesterov
2010-02-16 10:23 ` Andi Kleen
2010-02-16 14:01 ` Oleg Nesterov [this message]
2010-02-16 14:02 ` [PATCH 1/3] x86: set_personality_ia32() misses force_personality32 Oleg Nesterov
2010-02-16 23:27 ` [tip:x86/urgent] " tip-bot for Oleg Nesterov
2010-02-16 14:02 ` [PATCH 2/3] x86: set_personality_ia32() abuses TS_COMPAT Oleg Nesterov
2010-02-16 15:40 ` Linus Torvalds
2010-02-16 17:16 ` Oleg Nesterov
2010-02-16 17:38 ` H. Peter Anvin
2010-02-16 17:44 ` Oleg Nesterov
2010-02-16 17:51 ` H. Peter Anvin
2010-02-17 15:40 ` Oleg Nesterov
2010-02-16 18:43 ` Linus Torvalds
2010-02-16 14:03 ` [PATCH 3/3] x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32 Oleg Nesterov
2010-02-16 14:24 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216140126.GA16448@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).