From: Rodolfo Giometti <giometti@enneenne.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Anton Vorontsov <avorontsov@ru.mvista.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/4] power_supply: bq27x00: remove double endian swap
Date: Tue, 16 Feb 2010 17:22:24 +0100 [thread overview]
Message-ID: <20100216162223.GA28375@enneenne.com> (raw)
In-Reply-To: <1266011806-31747-1-git-send-email-notasas@gmail.com>
On Fri, Feb 12, 2010 at 11:56:46PM +0200, Grazvydas Ignotas wrote:
> The bq27x00 registers are little endian, so just read them as such
> and don't do double endian swap on LE machines.
>
> This also gets rid of strange looking shift that was done after
> reading 8bit register because endian swap in bq27x00_read() was
> messing it up.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Acked-by: Rodolfo Giometti <giometti@linux.it>
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
next prev parent reply other threads:[~2010-02-16 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 21:56 [PATCH 1/4] power_supply: bq27x00: remove double endian swap Grazvydas Ignotas
2010-02-16 16:22 ` Rodolfo Giometti [this message]
2010-02-16 18:36 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100216162223.GA28375@enneenne.com \
--to=giometti@enneenne.com \
--cc=avorontsov@ru.mvista.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox