Re: [PATCH v3 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge

Denis Turischev
2010-02-23T09:25:27Z

Hi Samuel,
Regarding renaming of sch* to isch* do you want incremental patch, or fresh version?

Denis

Jean Delvare wrote:
>> +static struct mfd_cell lpc_sch_cells[] = {
>> + {
>> + .name = "isch_smbus",
>> + .num_resources = 1,
>> + .resources = &smbus_sch_resource,
>> + },
>> + {
>> + .name = "sch_gpio",
>> + .num_resources = 1,
>> + .resources = &gpio_sch_resource,
>> + },
>> +};
>
> These names are nicely inconsistent. What about "isch_gpio"?
>

>> +obj-$(CONFIG_LPC_SCH) += lpc_sch.o
>
> I don't like this name either. There is another vendor (SMSC) shipping
> LPC devices with "SCH" in their names, so there is room for confusion.
> "isch" makes it clearer that we are talking about the Intel ones.
>