From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] backlight: Add support for exposing backlight types
Date: Wed, 17 Feb 2010 23:08:47 +0000 [thread overview]
Message-ID: <20100217230847.GA29144@srcf.ucam.org> (raw)
In-Reply-To: <1266447084.6436.483.camel@rex>
On Wed, Feb 17, 2010 at 10:51:24PM +0000, Richard Purdie wrote:
> What I'm interested in is how userspace is going to determine which
> driver(s) it should use?
>
> BACKLIGHT_GPU > BACKLIGHT_PLATFORM > BACKLIGHT_FIRMWARE ?
Other way around, at least on x86. We generally want to use as abstract
an approach as possible in order to ensure that we pick respond to
changes that the firmware has made.
> or something looking at the device names as well along with some kind of
> "XXX is better than YYY"?
In the hypothetical future where we can get plug-in displays with
backlights yeah.
> > + The type of interface controlled by <backlight>.
> > + "firmware": The driver uses a standard firmware interface
> > + "platform": The driver uses a platform-specific interface
> > + "gpu": The driver controls hardware registers directly
>
> These descriptions really don't help me much. I can think of several
> "platform" backlight drivers which control hardware registers directly.
> When people see these described as "gpu", I can see bug reports coming
> in. Would "raw" be a better description?
Sure.
> I'm also wondering how we associate backlights to displays. Lets say I
> have a three output video card which has a backlight control for each
> connected output. "gpu" isn't going to help me much and I suspect the
> framebuffer association code already in the backlight class won't help
> much either since nobody uses it and the framebuffer interfaces are
> mostly replaced with drm on desktops/laptops? Do we have any plans on
> how to handle this - its certainly a related problem.
Right now, control of anything other than internal displays is going to
involve ddcci which is a whole different set of constraints. The only
real way of handling that is going to be for userspace to look at the
parent device of the backlight, I think.
> As an aside for the patch itself, I'd like a note about the list of
> strings in backlight.c needing to be in sync with the ENUM.
Fair enough.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2010-02-17 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 21:39 [PATCH 1/2] backlight: Allow properties to be passed at registration Matthew Garrett
2010-02-17 21:39 ` [PATCH 2/2] backlight: Add support for exposing backlight types Matthew Garrett
2010-02-17 22:51 ` Richard Purdie
2010-02-17 23:08 ` Matthew Garrett [this message]
2010-02-18 18:05 ` [PATCH 2/2 v2] " Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217230847.GA29144@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox