From: Greg KH <greg@kroah.com>
To: "Hans J. Koch" <hjk@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Manuel Traut <manut@linutronix.de>
Subject: Re: [PATCH] UIO: Add a driver for Hilscher netX-based fieldbus cards
Date: Wed, 17 Feb 2010 15:35:47 -0800 [thread overview]
Message-ID: <20100217233547.GD12197@kroah.com> (raw)
In-Reply-To: <20100209191349.GE3229@local>
> --- linux-2.6.33-rc.orig/include/linux/pci_ids.h 2010-02-09 12:43:51.000000000 +0100
> +++ linux-2.6.33-rc/include/linux/pci_ids.h 2010-02-09 12:44:51.000000000 +0100
> @@ -137,6 +137,11 @@
>
> /* Vendors and devices. Sort key: vendor first, device next. */
>
> +#define PCI_VENDOR_ID_HILSCHER 0x15CF
> +#define PCI_DEVICE_ID_HILSCHER_NETX 0x0000
> +#define PCI_SUBDEVICE_ID_NXSB_PCA 0x3235
> +#define PCI_SUBDEVICE_ID_NXPCA 0x3335
This isn't needed, we don't add new device ids to the file, unless they
are used by more than one driver (see the comment at the top of the
file.)
I've fixed up the patch to not include this anymore.
thanks,
greg k-h
prev parent reply other threads:[~2010-02-18 0:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 19:13 [PATCH] UIO: Add a driver for Hilscher netX-based fieldbus cards Hans J. Koch
2010-02-17 23:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217233547.GD12197@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=manut@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox