public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	"David S . Miller" <davem@davemloft.net>,
	Paul Mundt <lethal@linux-sh.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic
Date: Thu, 18 Feb 2010 15:50:57 +0100	[thread overview]
Message-ID: <20100218145055.GB855@nowhere> (raw)
In-Reply-To: <8bd0f97a1002180601i60c5eaa4p7639091c5b617702@mail.gmail.com>

On Thu, Feb 18, 2010 at 09:01:12AM -0500, Mike Frysinger wrote:
> > --- a/arch/Kconfig
> > +++ b/arch/Kconfig
> > @@ -123,6 +123,10 @@ config USE_GENERIC_SMP_HELPERS
> >
> >  config HAVE_REGS_AND_STACK_ACCESS_API
> >        bool
> > +       help
> > +         This symbol should be selected by an architecure if it supports
> > +         the API needed to access registers and stack entries from pt_regs.
> > +         For example the kprobes-based event tracer needs this API.
> 
> a bit vague ... arent there headers/functions people could look at ?
> perhaps you're talking about the regset functions (which is an API to
> access registers in pt_regs) ?  or you're talking about asm/syscall.h
> (which is an API to access registers in pt_regs) ?
> 
> i'm not asking to be a pain, i'm asking because i really havent a
> clue.  if i wanted to add support for this stuff to the Blackfin arch,
> i wouldnt know where to start.  even after reading this help i'd fall
> back to grepping arch/x86/ and trying to divine a starting point from
> there.


If an arch support kprobes, it just needs to select
HAVE_REGS_AND_STACK_ACCESS_API to figure out quickly what is missing,
as gcc will barf every missing clues you need.

For now it is stored is asm/ptrace.h, but that might be split in
the future, especially as ptrace has initially nothing related to
that. A documentation that deals with filenames or API enumerations
tend to be incidentally async with API evolutions.

Hm?


  reply	other threads:[~2010-02-18 14:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-18 11:13 [GIT PULL] tracing updates Frederic Weisbecker
2010-02-18 11:13 ` [PATCH 1/3] tracing: Unify arch_syscall_addr() implementations Frederic Weisbecker
2010-02-18 11:13 ` [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic Frederic Weisbecker
2010-02-18 11:18   ` Mike Frysinger
2010-02-18 12:09     ` Heiko Carstens
2010-02-18 12:12       ` Mike Frysinger
2010-02-18 12:34         ` Frederic Weisbecker
2010-02-18 13:25           ` Heiko Carstens
2010-02-18 14:01             ` Mike Frysinger
2010-02-18 14:50               ` Frederic Weisbecker [this message]
2010-02-18 15:02                 ` Mike Frysinger
2010-02-18 15:43                   ` Frederic Weisbecker
2010-02-18 16:19                 ` Masami Hiramatsu
2010-02-18 18:13                   ` Frederic Weisbecker
2010-02-22  1:27                   ` Frederic Weisbecker
2010-02-22 14:23                     ` Masami Hiramatsu
2010-02-22 19:45                     ` Mike Frysinger
2010-02-18 15:00               ` Heiko Carstens
2010-02-18 15:08                 ` Mike Frysinger
2010-02-18 16:04               ` Masami Hiramatsu
2010-02-18 14:33             ` Frederic Weisbecker
2010-02-27 12:52             ` [tip:tracing/core] tracing/kprobes: Add short documentation for HAVE_REGS_AND_STACK_ACCESS_API tip-bot for Heiko Carstens
2010-02-18 11:13 ` [PATCH 3/3] s390: Add pt_regs register and stack access API Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100218145055.GB855@nowhere \
    --to=fweisbec@gmail.com \
    --cc=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox