public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 04/18] sysctl extern cleanup - binfmts
@ 2010-02-20 14:10 Dave Young
  0 siblings, 0 replies; only message in thread
From: Dave Young @ 2010-02-20 14:10 UTC (permalink / raw)
  To: Andrew Morton, Oleg Nesterov, Rusty Russell, Ivan Kokshaysky,
	David Howells, Ingo Molnar, Peter Zijlstra, James Morris,
	Eric W. Biederman, linux-kernel

Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move core_uses_pid/core_pattern/core_pipe_limit extern declarations
to linux/binfmts.h
suid_dumpable is declared in binfmts.h already.

Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
 include/linux/binfmts.h |    6 ++++++
 kernel/sysctl.c         |    5 +----
 2 files changed, 7 insertions(+), 4 deletions(-)

--- linux-2.6.32.orig/kernel/sysctl.c	2010-02-20 14:06:33.374900066 +0800
+++ linux-2.6.32/kernel/sysctl.c	2010-02-20 14:06:42.621567640 +0800
@@ -56,6 +56,7 @@
 #include <linux/rcustring.h>
 #include <linux/signal.h>
 #include <linux/threads.h>
+#include <linux/binfmts.h>
 
 #include <asm/uaccess.h>
 #include <asm/processor.h>
@@ -70,10 +71,6 @@
 #if defined(CONFIG_SYSCTL)
 
 /* External variables not in a header file. */
-extern int core_uses_pid;
-extern int suid_dumpable;
-extern char *core_pattern;
-extern unsigned int core_pipe_limit;
 extern int pid_max;
 extern int min_free_kbytes;
 extern int pid_max_min, pid_max_max;
--- linux-2.6.32.orig/include/linux/binfmts.h	2010-02-20 14:02:26.958258402 +0800
+++ linux-2.6.32/include/linux/binfmts.h	2010-02-20 14:06:42.621567640 +0800
@@ -20,6 +20,12 @@ struct pt_regs;
 #ifdef __KERNEL__
 #include <linux/list.h>
 
+#ifdef CONFIG_SYSCTL
+extern int core_uses_pid;
+extern char *core_pattern;
+extern unsigned int core_pipe_limit;
+#endif
+
 #define CORENAME_MAX_SIZE 128
 
 /*

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-02-20 14:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-20 14:10 [PATCH 04/18] sysctl extern cleanup - binfmts Dave Young

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox