From: Dave Young <hidave.darkstar@gmail.com>
To: Doug Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
James Morris <jmorris@namei.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 13/18] sysctl extern cleanup - sg
Date: Sat, 20 Feb 2010 22:19:03 +0800 [thread overview]
Message-ID: <20100220141903.GL3195@darkstar> (raw)
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move sg_big_buff extern declaration to scsi/sg.h
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
include/scsi/sg.h | 5 +++++
kernel/sysctl.c | 5 +----
2 files changed, 6 insertions(+), 4 deletions(-)
--- linux-2.6.32.orig/include/scsi/sg.h 2010-02-20 14:02:18.708258892 +0800
+++ linux-2.6.32/include/scsi/sg.h 2010-02-20 14:39:48.631369361 +0800
@@ -70,6 +70,11 @@ Major new features in SG 3.x driver (cf
(for the lk 2.2 series).
*/
+#ifdef __KERNEL__
+#if defined(CONFIG_SYSCTL) && defined(CONFIG_CHR_DEV_SG)
+extern int sg_big_buff;
+#endif
+#endif
/* New interface introduced in the 3.x SG drivers follows */
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-20 14:27:50.691439411 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-20 14:38:51.008872869 +0800
@@ -62,6 +62,7 @@
#include <linux/latencytop.h>
#include <linux/file.h>
#include <linux/blk-iopoll.h>
+#include <scsi/sg.h>
#include <asm/uaccess.h>
#include <asm/processor.h>
@@ -100,10 +101,6 @@ static int min_percpu_pagelist_fract = 8
static int ngroups_max = NGROUPS_MAX;
-#ifdef CONFIG_CHR_DEV_SG
-extern int sg_big_buff;
-#endif
-
#ifdef CONFIG_SPARC
#include <asm/system.h>
#endif
reply other threads:[~2010-02-20 14:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220141903.GL3195@darkstar \
--to=hidave.darkstar@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dgilbert@interlog.com \
--cc=ebiederm@xmission.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox