From: Dave Young <hidave.darkstar@gmail.com>
To: John McCutchan <john@johnmccutchan.com>,
Robert Love <rlove@rlove.org>, Eric Paris <eparis@parisplace.org>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
James Morris <jmorris@namei.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 18/18] sysctl extern cleanup - inotify
Date: Sat, 20 Feb 2010 22:23:12 +0800 [thread overview]
Message-ID: <20100220142312.GQ3195@darkstar> (raw)
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move inotify_table extern declaration to linux/inotify.h
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
include/linux/inotify.h | 6 ++++++
kernel/sysctl.c | 4 +---
2 files changed, 7 insertions(+), 3 deletions(-)
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-20 14:43:20.458847237 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-20 14:44:20.745507688 +0800
@@ -45,6 +45,7 @@
#include <linux/limits.h>
#include <linux/dcache.h>
#include <linux/dnotify.h>
+#include <linux/inotify.h>
#include <linux/syscalls.h>
#include <linux/vmstat.h>
#include <linux/nfs_fs.h>
@@ -160,9 +161,6 @@ static struct ctl_table fs_table[];
static struct ctl_table debug_table[];
static struct ctl_table dev_table[];
extern struct ctl_table random_table[];
-#ifdef CONFIG_INOTIFY_USER
-extern struct ctl_table inotify_table[];
-#endif
/* The default sysctl tables: */
--- linux-2.6.32.orig/include/linux/inotify.h 2010-02-20 14:02:15.074926187 +0800
+++ linux-2.6.32/include/linux/inotify.h 2010-02-20 14:44:20.745507688 +0800
@@ -69,4 +69,10 @@ struct inotify_event {
#define IN_CLOEXEC O_CLOEXEC
#define IN_NONBLOCK O_NONBLOCK
+#ifdef __KERNEL__
+#if defined(CONFIG_INOTIFY_USER) && defined(CONFIG_SYSCTL)
+extern struct ctl_table inotify_table[];
+#endif
+#endif
+
#endif /* _LINUX_INOTIFY_H */
reply other threads:[~2010-02-20 14:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220142312.GQ3195@darkstar \
--to=hidave.darkstar@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=john@johnmccutchan.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rlove@rlove.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox