From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>,
"Kernel development list" <linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: sysfs lockdep complaint
Date: Sat, 20 Feb 2010 23:20:10 +0800 [thread overview]
Message-ID: <20100220152010.GI3000@hack> (raw)
In-Reply-To: <1266678496.32309.1.camel@jlt3.sipsolutions.net>
On Sat, Feb 20, 2010 at 04:08:16PM +0100, Johannes Berg wrote:
>On Sat, 2010-02-20 at 23:03 +0800, Américo Wang wrote:
>
>> fct->fan_type = pwm_fan;
>> fct->ctrl.type = pwm_fan ? WF_CONTROL_PWM_FAN : WF_CONTROL_RPM_FAN;
>> + sysfs_attr_init(&fct->ctrl.attr);
>
>ah, needs to be "ctrl.attr.attr".
>
Ouch, right... Updated.
Thank you!
---
diff --git a/drivers/macintosh/windfarm_smu_controls.c b/drivers/macintosh/windfarm_smu_controls.c
index 6c68b9e..5f4e5a0 100644
--- a/drivers/macintosh/windfarm_smu_controls.c
+++ b/drivers/macintosh/windfarm_smu_controls.c
@@ -173,6 +173,7 @@ static struct smu_fan_control *smu_fan_create(struct device_node *node,
fct->fan_type = pwm_fan;
fct->ctrl.type = pwm_fan ? WF_CONTROL_PWM_FAN : WF_CONTROL_RPM_FAN;
+ sysfs_attr_init(&fct->ctrl.attr.attr);
/* We use the name & location here the same way we do for SMU sensors,
* see the comment in windfarm_smu_sensors.c. The locations are a bit
next prev parent reply other threads:[~2010-02-20 15:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 9:32 sysfs lockdep complaint Johannes Berg
2010-02-20 9:26 ` Américo Wang
2010-02-20 11:13 ` Johannes Berg
2010-02-20 13:54 ` Américo Wang
2010-02-20 14:00 ` Johannes Berg
2010-02-20 11:20 ` Johannes Berg
2010-02-20 13:51 ` Américo Wang
2010-02-20 13:58 ` Johannes Berg
2010-02-20 15:16 ` Américo Wang
2010-02-20 14:01 ` Johannes Berg
2010-02-20 15:03 ` Américo Wang
2010-02-20 15:07 ` Johannes Berg
2010-02-20 15:08 ` Johannes Berg
2010-02-20 15:20 ` Américo Wang [this message]
2010-02-20 15:28 ` Johannes Berg
2010-02-20 15:31 ` Johannes Berg
2010-02-20 15:44 ` Américo Wang
2010-02-20 15:44 ` Johannes Berg
2010-02-20 15:40 ` Américo Wang
2010-02-20 15:41 ` [PATCH] module: init sysfs attributes Johannes Berg
2010-02-20 15:43 ` [PATCH] windfarm: " Johannes Berg
2010-02-24 2:49 ` Benjamin Herrenschmidt
2010-02-24 7:32 ` Johannes Berg
2010-02-24 7:34 ` Américo Wang
2010-02-24 9:12 ` Johannes Berg
2010-02-25 1:43 ` Américo Wang
2010-03-08 7:46 ` Johannes Berg
2010-02-24 13:24 ` Greg KH
2010-02-25 1:46 ` Américo Wang
2010-02-20 15:14 ` sysfs lockdep complaint Johannes Berg
2010-02-20 15:31 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220152010.GI3000@hack \
--to=xiyou.wangcong@gmail.com \
--cc=ebiederm@xmission.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox