public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Avi Kivity <avi@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/11] KVM: SVM: Don't call instruction emulator for invd and wbinvd
Date: Sun, 21 Feb 2010 13:12:08 +0100	[thread overview]
Message-ID: <20100221121208.GJ20833@8bytes.org> (raw)
In-Reply-To: <4B81205D.1070608@redhat.com>

On Sun, Feb 21, 2010 at 02:00:29PM +0200, Avi Kivity wrote:
> On 02/21/2010 01:37 PM, Joerg Roedel wrote:
>> Weird. For some reason the Windows 7 XP emulation was executing wbinvd
>> which caused an nested intercept for the host level and the rip was not
>> advanced. So the nested guest did not advance and just produces wbinvd
>> intercepts all the time.
>>    
>
> Has the guest enabled wbinvd interception?  Perhaps not, so kvm has to  
> emulate wbinvd in the nested guest context, which is likely the only  
> case that we're called to do this.  So the problem might be in emulating  
> within the nested guest.

Probably, but this was running on nested-shadow where gva_to_gpa is
expected to work even when the vcpu is running in nested mode. I'll
check this again.

	Joerg


  reply	other threads:[~2010-02-21 12:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 15:22 [PATCH 0/11] Nested SVM fixes v2 Joerg Roedel
2010-02-19 15:23 ` [PATCH 01/11] KVM: SVM: Don't use kmap_atomic in nested_svm_map Joerg Roedel
2010-02-19 15:23 ` [PATCH 02/11] KVM: SVM: Fix wrong interrupt injection in enable_irq_windows Joerg Roedel
2010-02-22 10:29   ` Joerg Roedel
2010-02-22 11:05     ` Avi Kivity
2010-02-19 15:23 ` [PATCH 03/11] KVM: SVM: Fix schedule-while-atomic on nested exception handling Joerg Roedel
2010-02-19 15:23 ` [PATCH 04/11] KVM: SVM: Sync all control registers on nested vmexit Joerg Roedel
2010-02-19 15:23 ` [PATCH 05/11] KVM: SVM: Annotate nested_svm_map with might_sleep() Joerg Roedel
2010-02-19 15:23 ` [PATCH 06/11] KVM: SVM: Fix nested msr intercept handling Joerg Roedel
2010-02-19 15:23 ` [PATCH 07/11] KVM: SVM: Don't sync nested cr8 to lapic and back Joerg Roedel
2010-02-19 15:23 ` [PATCH 08/11] KVM: SVM: Activate nested state only when guest state is complete Joerg Roedel
2010-02-19 15:23 ` [PATCH 09/11] KVM: SVM: Make lazy FPU switching work with nested svm Joerg Roedel
2010-02-19 15:23 ` [PATCH 10/11] KVM: SVM: Remove newlines from nested trace points Joerg Roedel
2010-02-19 15:23 ` [PATCH 11/11] KVM: SVM: Don't call instruction emulator for invd and wbinvd Joerg Roedel
2010-02-21  9:53   ` Avi Kivity
2010-02-21 11:37     ` Joerg Roedel
2010-02-21 12:00       ` Avi Kivity
2010-02-21 12:12         ` Joerg Roedel [this message]
2010-02-21  9:56 ` [PATCH 0/11] Nested SVM fixes v2 Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100221121208.GJ20833@8bytes.org \
    --to=joro@8bytes.org \
    --cc=avi@redhat.com \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox