* [PATCH -mm 09/17] sysctl extern cleanup - rcu
@ 2010-02-21 14:24 Dave Young
2010-02-21 16:58 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Dave Young @ 2010-02-21 14:24 UTC (permalink / raw)
To: Dipankar Sarma, Paul E. McKenney, Ingo Molnar, Lai Jiangshan,
Vegard Nossum, Josh Triplett, Andrew Morton, Peter Zijlstra,
James Morris, Eric W. Biederman, linux-kernel
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move rcutorture_runnable extern declaration to linux/rcupdate.h
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Acked-by: Josh Triplett <josh@joshtriplett.org>
---
include/linux/rcupdate.h | 4 ++++
kernel/sysctl.c | 3 ---
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.32.orig/include/linux/rcupdate.h 2010-02-21 09:35:58.013190490 +0800
+++ linux-2.6.32/include/linux/rcupdate.h 2010-02-21 10:03:53.296358225 +0800
@@ -41,6 +41,10 @@
#include <linux/lockdep.h>
#include <linux/completion.h>
+#ifdef CONFIG_RCU_TORTURE_TEST
+extern int rcutorture_runnable; /* for sysctl */
+#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
+
/**
* struct rcu_head - callback structure for use with RCU
* @next: next update requests in a list
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 09:58:40.029722800 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-21 10:01:30.257204779 +0800
@@ -75,9 +75,6 @@
/* External variables not in a header file. */
extern int max_threads;
-#ifdef CONFIG_RCU_TORTURE_TEST
-extern int rcutorture_runnable;
-#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
#ifdef CONFIG_BLOCK
extern int blk_iopoll_enabled;
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -mm 09/17] sysctl extern cleanup - rcu
2010-02-21 14:24 [PATCH -mm 09/17] sysctl extern cleanup - rcu Dave Young
@ 2010-02-21 16:58 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2010-02-21 16:58 UTC (permalink / raw)
To: Dave Young
Cc: Dipankar Sarma, Ingo Molnar, Lai Jiangshan, Vegard Nossum,
Josh Triplett, Andrew Morton, Peter Zijlstra, James Morris,
Eric W. Biederman, linux-kernel
On Sun, Feb 21, 2010 at 10:24:12PM +0800, Dave Young wrote:
> Extern declarations in sysctl.c should be move to their own head file,
> and then include them in relavant .c files.
>
> Move rcutorture_runnable extern declaration to linux/rcupdate.h
Reviewed-by: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
> Acked-by: Josh Triplett <josh@joshtriplett.org>
> ---
> include/linux/rcupdate.h | 4 ++++
> kernel/sysctl.c | 3 ---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> --- linux-2.6.32.orig/include/linux/rcupdate.h 2010-02-21 09:35:58.013190490 +0800
> +++ linux-2.6.32/include/linux/rcupdate.h 2010-02-21 10:03:53.296358225 +0800
> @@ -41,6 +41,10 @@
> #include <linux/lockdep.h>
> #include <linux/completion.h>
>
> +#ifdef CONFIG_RCU_TORTURE_TEST
> +extern int rcutorture_runnable; /* for sysctl */
> +#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
> +
> /**
> * struct rcu_head - callback structure for use with RCU
> * @next: next update requests in a list
> --- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 09:58:40.029722800 +0800
> +++ linux-2.6.32/kernel/sysctl.c 2010-02-21 10:01:30.257204779 +0800
> @@ -75,9 +75,6 @@
>
> /* External variables not in a header file. */
> extern int max_threads;
> -#ifdef CONFIG_RCU_TORTURE_TEST
> -extern int rcutorture_runnable;
> -#endif /* #ifdef CONFIG_RCU_TORTURE_TEST */
> #ifdef CONFIG_BLOCK
> extern int blk_iopoll_enabled;
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-21 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-21 14:24 [PATCH -mm 09/17] sysctl extern cleanup - rcu Dave Young
2010-02-21 16:58 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox