* [PATCH -mm 16/17] sysctl extern cleanup - poll
@ 2010-02-21 14:25 Dave Young
0 siblings, 0 replies; only message in thread
From: Dave Young @ 2010-02-21 14:25 UTC (permalink / raw)
To: Oleg Nesterov, Andrew Morton, Ulrich Drepper, Thomas Gleixner,
Roland McGrath, Ingo Molnar, Peter Zijlstra, James Morris,
Eric W. Biederman, linux-kernel
Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.
Move epoll_table extern declaration to linux/poll.h
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
include/linux/poll.h | 2 ++
kernel/sysctl.c | 6 +++---
2 files changed, 5 insertions(+), 3 deletions(-)
--- linux-2.6.32.orig/include/linux/poll.h 2010-02-21 11:12:11.850112707 +0800
+++ linux-2.6.32/include/linux/poll.h 2010-02-21 11:26:29.549195967 +0800
@@ -10,8 +10,10 @@
#include <linux/wait.h>
#include <linux/string.h>
#include <linux/fs.h>
+#include <linux/sysctl.h>
#include <asm/uaccess.h>
+extern struct ctl_table epoll_table[]; /* for sysctl */
/* ~832 bytes of stack space used max in sys_select/sys_poll before allocating
additional memory. */
#define MAX_STACK_ALLOC 832
--- linux-2.6.32.orig/kernel/sysctl.c 2010-02-21 11:23:13.929215242 +0800
+++ linux-2.6.32/kernel/sysctl.c 2010-02-21 11:25:35.455865983 +0800
@@ -72,6 +72,9 @@
#if defined(CONFIG_PROVE_LOCKING) || defined(CONFIG_LOCK_STAT)
#include <linux/lockdep.h>
#endif
+#ifdef CONFIG_EPOLL
+#include <linux/poll.h>
+#endif
#ifdef CONFIG_CHR_DEV_SG
#include <scsi/sg.h>
#endif
@@ -174,9 +177,6 @@ extern struct ctl_table random_table[];
#ifdef CONFIG_INOTIFY_USER
extern struct ctl_table inotify_table[];
#endif
-#ifdef CONFIG_EPOLL
-extern struct ctl_table epoll_table[];
-#endif
/* The default sysctl tables: */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-02-21 14:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-21 14:25 [PATCH -mm 16/17] sysctl extern cleanup - poll Dave Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox