public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -mm 17/17] sysctl extern cleanup - inotify
@ 2010-02-21 14:25 Dave Young
  0 siblings, 0 replies; only message in thread
From: Dave Young @ 2010-02-21 14:25 UTC (permalink / raw)
  To: John McCutchan, Robert Love, Eric Paris, Ingo Molnar,
	Andrew Morton, Peter Zijlstra, James Morris, Eric W. Biederman,
	linux-kernel

Extern declarations in sysctl.c should be move to their own head file,
and then include them in relavant .c files.

Move inotify_table extern declaration to linux/inotify.h

Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
 include/linux/inotify.h |    5 +++++
 kernel/sysctl.c         |    6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)

--- linux-2.6.32.orig/kernel/sysctl.c	2010-02-21 11:25:35.455865983 +0800
+++ linux-2.6.32/kernel/sysctl.c	2010-02-21 11:27:43.782519869 +0800
@@ -75,6 +75,9 @@
 #ifdef CONFIG_EPOLL
 #include <linux/poll.h>
 #endif
+#ifdef CONFIG_INOTIFY_USER
+#include <linux/inotify.h>
+#endif
 #ifdef CONFIG_CHR_DEV_SG
 #include <scsi/sg.h>
 #endif
@@ -174,9 +177,6 @@ static struct ctl_table fs_table[];
 static struct ctl_table debug_table[];
 static struct ctl_table dev_table[];
 extern struct ctl_table random_table[];
-#ifdef CONFIG_INOTIFY_USER
-extern struct ctl_table inotify_table[];
-#endif
 
 /* The default sysctl tables: */
 
--- linux-2.6.32.orig/include/linux/inotify.h	2010-02-21 11:25:35.465866403 +0800
+++ linux-2.6.32/include/linux/inotify.h	2010-02-21 11:28:20.686684371 +0800
@@ -69,4 +69,9 @@ struct inotify_event {
 #define IN_CLOEXEC O_CLOEXEC
 #define IN_NONBLOCK O_NONBLOCK
 
+#ifdef __KERNEL__
+#include <linux/sysctl.h>
+extern struct ctl_table inotify_table[]; /* for sysctl */
+#endif
+
 #endif	/* _LINUX_INOTIFY_H */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-02-21 14:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-21 14:25 [PATCH -mm 17/17] sysctl extern cleanup - inotify Dave Young

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox