Re: [PATCH v2 2/2] enhance sysfs rfkill interface

Marcel Holtmann
2010-02-26T13:09:42Z

Hi Florian,

> > > I am not shure about those names.
> >
> > I don't like them. IMHO, you don't gain anything by being this terse, and
> > it is difficult to understand what they mean at first glance.
> >
> > > Other alternatives:
> > > [hs]w_block
> > > block_[hs]w
> >
>
> I made that blocked_sw and blocked_hw, so that they are
> lexicographically nearby and that they also give more information about
> their content.
>
> blocked_[hs]w -> 0/1 makes IMO kind of sense.

the kernel and /dev/rfkill just talks about "hard" and "soft" blocks.

Don't confuse this with hardware and software. It seems were are keeping
to make this stupid semantical error over and over again. So everything
that says hardware, software, hw or sw in the API is bluntly wrong.

Regards

Marcel