Re: [PATCH v2 2/2] enhance sysfs rfkill interface

Henrique de Moraes Holschuh
2010-02-25T23:45:54Z

On Wed, 24 Feb 2010, florian@mickler.org wrote:
> /sys/class/rfkill/rfkill[0-9]+/hw: (ro)
> hardblock kill state
> /sys/class/rfkill/rfkill[0-9]+/sw: (rw)
> softblock kill state
>
> Signed-off-by: Florian Mickler <florian@mickler.org>
> ---
>
> I am not shure about those names.

I don't like them. IMHO, you don't gain anything by being this terse, and
it is difficult to understand what they mean at first glance.

> Other alternatives:
> [hs]w_block
> block_[hs]w

Any of those would be good, IMHO. As would be more verbose variants like:
hardware_blocked, software_blocked, etc.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh