From: Russ Anderson <rja@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
tglx@linutronix.de, linux-kernel@vger.kernel.org, rja@sgi.com
Subject: Re: [PATCH] x86: Enable NMI on all cpus on UV
Date: Mon, 22 Feb 2010 16:24:51 -0600 [thread overview]
Message-ID: <20100222222451.GA14040@sgi.com> (raw)
In-Reply-To: <20100222103853.GA14522@elte.hu>
On Mon, Feb 22, 2010 at 11:38:53AM +0100, Ingo Molnar wrote:
>
> * Russ Anderson <rja@sgi.com> wrote:
>
> > Index: linux/arch/x86/kernel/smpboot.c
> > ===================================================================
> > --- linux.orig/arch/x86/kernel/smpboot.c 2010-02-17 10:21:55.000000000 -0600
> > +++ linux/arch/x86/kernel/smpboot.c 2010-02-17 10:32:20.000000000 -0600
> > @@ -320,6 +320,8 @@ notrace static void __cpuinit start_seco
> > unlock_vector_lock();
> > ipi_call_unlock();
> > per_cpu(cpu_state, smp_processor_id()) = CPU_ONLINE;
> > + if (is_uv_system())
> > + uv_nmi_init();
>
> Instead of cramming it into the init sequence open-coded, shouldnt this be
> done via the x86_platform driver mechanism?
OK, I'm working on it.
> Thanks,
>
> Ingo
Thanks,
--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@sgi.com
next prev parent reply other threads:[~2010-02-22 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 16:50 [PATCH] x86: Enable NMI on all cpus on UV Russ Anderson
2010-02-22 10:38 ` Ingo Molnar
2010-02-22 22:24 ` Russ Anderson [this message]
2010-02-25 17:24 ` Russ Anderson
2010-02-26 9:22 ` Ingo Molnar
2010-02-26 16:49 ` Russ Anderson
2010-02-27 11:35 ` Ingo Molnar
2010-02-27 12:56 ` [tip:x86/pci] " tip-bot for Russ Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222222451.GA14040@sgi.com \
--to=rja@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).