From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754935Ab0BVXYd (ORCPT ); Mon, 22 Feb 2010 18:24:33 -0500 Received: from mail-fx0-f219.google.com ([209.85.220.219]:42119 "EHLO mail-fx0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643Ab0BVXYc (ORCPT ); Mon, 22 Feb 2010 18:24:32 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=juNVPtjtt1tITmDU/lNnD9ZcwtiMyO9CdtWKKaeIbeP27avWKhCgrsvlGK7mHahLWw MUs+XYISLtgTggl2wOCIZ5DV7Cq+sDVAo0rR5YFpf7aZeHvkkm2lTj1gX87VWGvDIjfe rkISkDnv+DZBnQbbcJIa1bAjshrA9g/14rCno= Date: Tue, 23 Feb 2010 02:24:27 +0300 From: Cyrill Gorcunov To: Don Zickus Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, peterz@infradead.org, aris@redhat.com Subject: Re: [PATCH] nmi_watchdog: checkpatch.pl cleanups from earlier patches Message-ID: <20100222232427.GB20084@lenovo> References: <1266880143-24943-1-git-send-email-dzickus@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1266880143-24943-1-git-send-email-dzickus@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2010 at 06:09:03PM -0500, Don Zickus wrote: ... Hi Don! > diff --git a/kernel/nmi_watchdog.c b/kernel/nmi_watchdog.c > index 3c75cbf..0a6f57f 100644 > --- a/kernel/nmi_watchdog.c > +++ b/kernel/nmi_watchdog.c > @@ -50,31 +50,31 @@ void touch_all_nmi_watchdog(void) > > static int __init setup_nmi_watchdog(char *str) > { > - if (!strncmp(str, "panic", 5)) { > - panic_on_timeout = 1; > - str = strchr(str, ','); > - if (!str) > - return 1; > - ++str; > - } > - return 1; > + if (!strncmp(str, "panic", 5)) { > + panic_on_timeout = 1; If I understand all the things correct -- you don't need to check for ',' after panic. It seems so. Because we're switching to perf_events I suppose we may drop expecting "lapic,ioapic" or whatever here? Or there is an idea to parse say "panic,software" (ie to switch to software events by default)? Though strictly speaking my question in rather unrelated to this patch agenda :) > + str = strchr(str, ','); > + if (!str) > + return 1; > + ++str; > + } > + return 1; > } > __setup("nmi_watchdog=", setup_nmi_watchdog); ... -- Cyrill