From: Borislav Petkov <bp@amd64.org>
To: viresh kumar <viresh.linux@gmail.com>
Cc: Borislav Petkov <petkovbb@googlemail.com>, linux-kernel@vger.kernel.org
Subject: Re: QUERY: Inclusion of header files in kernel header files
Date: Tue, 23 Feb 2010 14:01:28 +0100 [thread overview]
Message-ID: <20100223130128.GB30382@aftab> (raw)
In-Reply-To: <22dbbef21002230337i104c63dcm5d59064ca48a07f0@mail.gmail.com>
From: viresh kumar <viresh.linux@gmail.com>
Date: Tue, Feb 23, 2010 at 05:07:47PM +0530
> >> I think, ideally including any header file shouldn't give compilation
> >> errors for types used in
> >> included header file.
> >
> > Agreed.
> >
> > I'd send a patch fixing the bus.h header, in case no one has a valid
> > technical reason against it.
> >
>
> That will be great!!!
Just to make sure: with "I'd" I meant "I would", i.e. actually _you_
could send a patch fixing that by explaining the problem in the commit
message :).
> Actually this issue is not present only in bus.h, but some other
> kernel header files.
> Like: arch/arm/include/asm/clkdev.h don't include list.h file but
> using struct list_head
>
> May be we need to check this in other header files also.
Well, you should talk to the arm maintainer about that task and whether
it is desirable.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2010-02-23 13:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <22dbbef21002222241h711402f1me6b60ac7502cccd4@mail.gmail.com>
2010-02-23 6:43 ` QUERY: Inclusion of header files in kernel header files viresh kumar
2010-02-23 6:59 ` Borislav Petkov
2010-02-23 7:31 ` viresh kumar
2010-02-23 9:50 ` Borislav Petkov
2010-02-23 11:37 ` viresh kumar
2010-02-23 13:01 ` Borislav Petkov [this message]
2010-02-23 13:59 ` Stefan Richter
2010-02-24 4:23 ` viresh kumar
2010-02-23 15:15 ` Theodore Tso
2010-02-24 4:28 ` viresh kumar
2010-02-24 7:02 ` Theodore Tso
2010-02-24 10:38 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223130128.GB30382@aftab \
--to=bp@amd64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@googlemail.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox