public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/14] Regulators: max1586 - annotate probe and remove methods
Date: Wed, 24 Feb 2010 02:16:08 -0800	[thread overview]
Message-ID: <201002240216.08893.dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20100224100654.GD18896@rakim.wolfsonmicro.main>

Hi Mark,

On Wednesday 24 February 2010 02:06:55 am Mark Brown wrote:
> On Tue, Feb 23, 2010 at 11:38:23PM -0800, Dmitry Torokhov wrote:
> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> >  	.driver		= {
> >  		.name	= "max1586",
> > +		.owner	= THIS_MODULE,
> >  	},
> 
> Note that a large number of your patches introduce this change and none
> of them note it in the changelog...
> 

Thanks for reviewing the lot.

Yes, I quite often list only most important changes in the log, and just
throw stuff like this in because I prefer to work on driver by driver
basis and splitting everything up produce twice as many patches. I will
try to be more detailed in my future submissions. 

-- 
Dmitry

  reply	other threads:[~2010-02-24 10:24 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24  7:37 [PATCH 00/14] Assorted small patches for regulators Dmitry Torokhov
2010-02-24  7:37 ` [PATCH 01/14] Regulators: virtual - use sysfs attribute groups Dmitry Torokhov
2010-02-24 10:50   ` Mark Brown
2010-02-25 10:35   ` Liam Girdwood
2010-02-24  7:37 ` [PATCH 02/14] Regulators: ab3100 - fix probe and remove annotations Dmitry Torokhov
2010-02-24 10:03   ` Mark Brown
2010-02-25 10:36   ` Liam Girdwood
2010-02-24  7:37 ` [PATCH 03/14] Regulators: fixed - annotate probe and remove methods Dmitry Torokhov
2010-02-24 10:43   ` Mark Brown
2010-02-25 10:36   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 04/14] Regulators: twl-regulator - mark probe function as __devinit Dmitry Torokhov
2010-02-24 10:05   ` Mark Brown
2010-02-25 10:36   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 05/14] Regulators: tps65023-regulator - mark probe method " Dmitry Torokhov
2010-02-24 11:31   ` Mark Brown
2010-02-25 10:37   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 06/14] Regulators: tps6507x-regulator " Dmitry Torokhov
2010-02-24 11:32   ` Mark Brown
2010-02-25 10:37   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 07/14] Regulators: lp3971 - fail if platform data was not supplied Dmitry Torokhov
2010-02-24 12:11   ` Mark Brown
2010-02-25 10:37   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 08/14] Regulators: max1586 - annotate probe and remove methods Dmitry Torokhov
2010-02-24 10:06   ` Mark Brown
2010-02-24 10:16     ` Dmitry Torokhov [this message]
2010-02-25 10:37   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 09/14] Regulators: max8660 " Dmitry Torokhov
2010-02-24 10:07   ` Mark Brown
2010-02-25 10:37   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 10/14] Regulators: pcap-regulator - clean up driver data after removal Dmitry Torokhov
2010-02-24 10:36   ` Mark Brown
2010-02-25 10:38   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 11/14] Regulators: wm831x-xxx " Dmitry Torokhov
2010-02-24 10:36   ` Mark Brown
2010-02-25 10:38   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 12/14] Regulators: wm8994 " Dmitry Torokhov
2010-02-24 10:20   ` Mark Brown
2010-02-25 10:39   ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 13/14] Regulators: wm8400 - cleanup platform driver data handling Dmitry Torokhov
2010-02-24 10:25   ` Mark Brown
2010-02-24 19:02     ` Dmitry Torokhov
2010-02-24 19:14       ` Mark Brown
2010-02-24 19:21         ` Dmitry Torokhov
2010-02-24 20:40           ` Mark Brown
2010-02-25  9:55             ` Dmitry Torokhov
2010-02-25 10:43               ` Mark Brown
2010-02-25 11:02               ` Liam Girdwood
2010-02-24  7:38 ` [PATCH 14/14] Regulators: max8925-regulator - clean up driver data after removal Dmitry Torokhov
2010-02-24 10:28   ` Mark Brown
2010-02-25 10:39   ` Liam Girdwood
2010-02-24 10:03 ` [PATCH 00/14] Assorted small patches for regulators Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002240216.08893.dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox