public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Tom Van Braeckel <tomvanbraeckel@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: Reminder: [PATCH 1/1] Staging: samsung-laptop: fix coding style
Date: Wed, 24 Feb 2010 05:58:33 -0800	[thread overview]
Message-ID: <20100224135833.GA22414@suse.de> (raw)
In-Reply-To: <48d47a051002240545j191214b8q85513be58b738726@mail.gmail.com>

"Reminder"?  What is that in the Subject: for?

On Wed, Feb 24, 2010 at 02:45:38PM +0100, Tom Van Braeckel wrote:
> Signed-off-by: Tom Van Braeckel <tomvanbraeckel@gmail.com>
> ---
>  drivers/staging/samsung-
> laptop/samsung-laptop.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c
> b/drivers/staging/samsung-laptop/samsung-laptop.c
> index 4877138..dd7ea4c 100644
> --- a/drivers/staging/samsung-laptop/samsung-laptop.c
> +++ b/drivers/staging/samsung-laptop/samsung-laptop.c
> @@ -99,7 +99,8 @@ static struct rfkill *rfk;
> 
>  static int force;
>  module_param(force, bool, 0);
> -MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be
> loaded");

Your patch is line-wrapped :(


> +MODULE_PARM_DESC(force,
> +               "Disable the DMI check and forces the driver to be loaded");

And the tabs are not here either.

and also, someone already sent in this fix, sorry.

thanks,

greg k-h

           reply	other threads:[~2010-02-24 14:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <48d47a051002240545j191214b8q85513be58b738726@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100224135833.GA22414@suse.de \
    --to=gregkh@suse.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomvanbraeckel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox