From: Andrew Morton <akpm@linux-foundation.org>
To: Ben Gardner <gardner.ben@gmail.com>
Cc: Andres Salomon <dilinger@collabora.co.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cs5535_gpio: gpio_chip.get should return the input value
Date: Wed, 24 Feb 2010 14:58:22 -0800 [thread overview]
Message-ID: <20100224145822.803e86ed.akpm@linux-foundation.org> (raw)
In-Reply-To: <808c8e9d1002231455q379b26acq4b4a50188c5d73be@mail.gmail.com>
On Tue, 23 Feb 2010 16:55:17 -0600 Ben Gardner <gardner.ben@gmail.com> wrote:
> The gpio_chip.get() function for the CS5535 GPIO driver currently returns the
> output value instead of the input value.
> This patch changes it to return the input value.
>
> Signed-off-by: Ben Gardner <gardner.ben@gmail.com>
> ---
> --- linux-2.6.33-rc8.orig/drivers/gpio/cs5535-gpio.c
> +++ linux-2.6.33-rc8/drivers/gpio/cs5535-gpio.c
> @@ -154,7 +154,7 @@
>
> static int chip_gpio_get(struct gpio_chip *chip, unsigned offset)
> {
> - return cs5535_gpio_isset(offset, GPIO_OUTPUT_VAL);
> + return cs5535_gpio_isset(offset, GPIO_READ_BACK);
> }
>
> static void chip_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
<presses F10>
What were the user-visible effects of this bug?
next prev parent reply other threads:[~2010-02-24 22:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 22:55 [PATCH] cs5535_gpio: gpio_chip.get should return the input value Ben Gardner
2010-02-24 22:58 ` Andrew Morton [this message]
2010-02-25 3:52 ` Ben Gardner
2010-02-25 4:05 ` Andrew Morton
2010-02-25 4:16 ` Ben Gardner
2010-02-25 5:04 ` Andres Salomon
2010-02-24 23:42 ` Andres Salomon
2010-02-24 23:45 ` [PATCH] OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input Andres Salomon
2010-02-26 17:47 ` Ben Gardner
2010-02-26 21:07 ` Andres Salomon
2010-02-26 23:32 ` Ben Gardner
2010-03-01 14:55 ` Ben Gardner
2010-03-01 15:17 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224145822.803e86ed.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dilinger@collabora.co.uk \
--cc=gardner.ben@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox