From: Greg KH <gregkh@suse.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, kay.sievers@vrfy.org,
benh@kernel.crashing.org
Subject: Re: [RFC] driver-core: Add device node pointer to struct device
Date: Wed, 24 Feb 2010 13:44:42 -0800 [thread overview]
Message-ID: <20100224214442.GB18437@suse.de> (raw)
In-Reply-To: <20100224210514.16289.86611.stgit@angua>
On Wed, Feb 24, 2010 at 02:10:30PM -0700, Grant Likely wrote:
> Greg and Kay,
>
> This is a patch from a larger series of OF related cleanup patches. This
> one adds a new 'of_node' member to struct device, conditional upon
> CONFIG_OF. The goal is to move of_node out of archdata because all
> arches using CONFIG_OF need it.
>
> Before I commit too much effort down this path, I want to get your
> feedback. Do you have any objections to this change to struct device?
>
> @@ -414,6 +415,9 @@ struct device {
> override */
> /* arch specific additions */
> struct dev_archdata archdata;
> +#ifdef CONFIG_OF
> + struct device_node *of_node;
> +#endif
No objection from me, but do we really need the #ifdef here?
> Full patch follows...
Do you want to take this patch through your tree? If so, feel free to
add:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to the patch.
If not, let me know and I'll take it through my tree.
Glad to see this work coming along, nice job.
thanks,
greg k-h
next prev parent reply other threads:[~2010-02-24 21:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 21:10 [RFC] driver-core: Add device node pointer to struct device Grant Likely
2010-02-24 21:44 ` Greg KH [this message]
2010-02-24 22:09 ` Grant Likely
2010-02-24 22:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224214442.GB18437@suse.de \
--to=gregkh@suse.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox