From: Greg KH <greg@kroah.com>
To: Serge Hallyn <serue@us.ibm.com>
Cc: rsc@swtch.com, Ashwin Ganti <ashwin.ganti@gmail.com>,
ericvh@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Ron Minnich <rminnich@gmail.com>
Subject: Re: [PATCH 1/8] p9auth: set fsuid
Date: Thu, 25 Feb 2010 15:28:40 -0800 [thread overview]
Message-ID: <20100225232840.GB24155@kroah.com> (raw)
In-Reply-To: <1266360301-30081-1-git-send-email-serue@us.ibm.com>
On Tue, Feb 16, 2010 at 04:44:54PM -0600, Serge Hallyn wrote:
> From: Serge E. Hallyn <serue@us.ibm.com>
>
> fsuid should always trail euid changes. So p9auth should
> set fsuid as well when it sets ruid and euid. Whether the
> suid should also be set is an open question - keeping the
> old uid in suid may be useful, or may just serve to trick
> lazy userspace.
>
> Note that so long as we do not also set suid, the setuid_fixup()
> code will not (when we later switch to setresuid()) fully
> fill/clear capability sets. So while I had previously thought
> that keeping suid unchanged would be useful, I think it is
> better to change all uids.
What is your goal for the p9auth code? Currently it is deleted in
linux-next due to a lack of development. I see you have some cleanup
patches, but I can't apply them unless you get the non-staging patches
accepted.
If I bring the driver back from deletion, will you work to fix it up and
get it merged into mainline?
What's the word on the non-staging patches in this series being
accepted?
thanks,
greg k-h
next prev parent reply other threads:[~2010-02-26 0:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 22:44 [PATCH 1/8] p9auth: set fsuid Serge Hallyn
2010-02-16 22:44 ` [PATCH 2/8] p9auth: split core function out of some set*{u,g}id functions Serge Hallyn
2010-02-16 22:44 ` [PATCH 3/8] p9auth: use setresuid Serge Hallyn
2010-02-16 22:44 ` [PATCH 4/8] p9auth: add CAP_GRANT_ID to authorize use of /dev/caphash Serge Hallyn
2010-02-16 22:44 ` [PATCH 5/8] p9auth cleanup Serge Hallyn
2010-02-16 22:44 ` [PATCH 6/8] p9auth: do groups Serge Hallyn
2010-02-16 22:45 ` [PATCH 7/8] p9auth: add cap_node timeout Serge Hallyn
2010-02-16 22:45 ` [PATCH 8/8] p9auth: don't trim entries on write-only open Serge Hallyn
2010-02-25 23:28 ` Greg KH [this message]
2010-02-26 4:05 ` [PATCH 1/8] p9auth: set fsuid Serge E. Hallyn
2010-02-26 5:06 ` Greg KH
2010-02-26 18:19 ` Serge E. Hallyn
2010-03-04 22:04 ` Ashwin Ganti
2010-03-05 20:07 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225232840.GB24155@kroah.com \
--to=greg@kroah.com \
--cc=ashwin.ganti@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rminnich@gmail.com \
--cc=rsc@swtch.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox