From: Dan Carpenter <error27@gmail.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "David S. Miller" <davem@davemloft.net>,
"Jeremy Kerr" <jeremy.kerr@canonical.com>,
"Andy Fleming" <afleming@freescale.com>,
"Jérôme Pouiller" <jezz@sysmic.org>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: [patch] of: check for IS_ERR()
Date: Fri, 26 Feb 2010 12:49:41 +0300 [thread overview]
Message-ID: <20100226094941.GE4912@bicker> (raw)
get_phy_device() can return an ERR_PTR()
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I don't have a cross compile environment set up so I can't even compile
test this. :/ But err.h is included so it should be OK.
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index 18ecae4..b474833 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -69,7 +69,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
}
phy = get_phy_device(mdio, be32_to_cpup(addr));
- if (!phy) {
+ if (!phy || IS_ERR(phy)) {
dev_err(&mdio->dev, "error probing PHY at address %i\n",
*addr);
continue;
next reply other threads:[~2010-02-26 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 9:49 Dan Carpenter [this message]
2010-02-26 9:54 ` [patch] of: check for IS_ERR() David Miller
2010-02-26 16:11 ` Grant Likely
2010-03-29 15:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226094941.GE4912@bicker \
--to=error27@gmail.com \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jeremy.kerr@canonical.com \
--cc=jezz@sysmic.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox