From: Greg KH <greg@kroah.com>
To: Jonathan Cameron <kernel@jic23.retrosnub.co.uk>
Cc: Nitin Shah <Nitin.Shah@kpitcummins.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: Touch Screen Drivers for Dialog da9052
Date: Fri, 26 Feb 2010 08:37:02 -0800 [thread overview]
Message-ID: <20100226163702.GE16213@kroah.com> (raw)
In-Reply-To: <4B87CEE4.9090104@jic23.retrosnub.co.uk>
On Fri, Feb 26, 2010 at 01:38:44PM +0000, Jonathan Cameron wrote:
> On 02/26/10 12:36, Nitin Shah wrote:
> > Hi,
> >
> > We have developed Touch Screen (TSI) Drivers for Dialog da9052 Power
> > Management IC.
> >
> > We have tested this driver on Samsung SMDK-6410 board. If any one
> > needs test application tor testing this driver, we will provide the
> > same which we have used for testing.
> >
> > For more details about the attached drives please refer the README
> > file inside "da9052_drivers.zip".
> >
> > We would like to incorporate this driver into Linux mainline kernel.
> >
> > Please test the driver and provide your valuable comments and
> > feedback.
> >
> > Thanks & Regards, Nitin Shah
> Hi Nitin,
>
> Couple of initial points. Please take a look at the guidance on
> Submitting patches in the Documentation directory of the linux
> kernel source tree. To get more eyes on code you need to make it
> as simple as possible for people to take a look!
>
> To move this driver set towards merging, take a look at how the other
> da90xx chips are handled in the current kernel. Given the chips have
> a lot of different functionality fitting into numerous corners of the
> kernel, that a given user may or may not want to use, they are implemented
> as multifunction devices (drivers/mfd) with children in a number of other
> subsystems.
>
> Whilst the code you have sent is pretty clear and well commented etc, it
> is going to need a lot of changes to interface with the relevant kernel
> subsystems.
>
> Perhaps this is one for staging?
I'll take anything for staging, it just has to build and be
self-contained and have someone who is working on getting it merged to
the main kernel tree.
thanks,
greg k-h
prev parent reply other threads:[~2010-02-26 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 12:36 Touch Screen Drivers for Dialog da9052 Nitin Shah
2010-02-26 13:31 ` Trilok Soni
2010-02-26 13:38 ` Jonathan Cameron
2010-02-26 16:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100226163702.GE16213@kroah.com \
--to=greg@kroah.com \
--cc=Nitin.Shah@kpitcummins.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@jic23.retrosnub.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox