Touch Screen Drivers for Dialog da9052

Touch Screen Drivers for Dialog da9052

[Nitin Shah]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

Hi,

We have developed Touch Screen (TSI) Drivers for Dialog da9052 Power Management IC.

We have tested this driver on Samsung SMDK-6410 board. If any one needs test application tor testing this driver, we will provide the same which we have used for testing.

For more details about the attached drives please refer the README file inside "da9052_drivers.zip".

We would like to incorporate this driver into Linux mainline kernel.

Please test the driver and provide your valuable comments and feedback.

Thanks & Regards,
Nitin Shah

[-- Attachment #2: da9052_drivers.zip --]
[-- Type: application/x-zip-compressed, Size: 112619 bytes --]

Re: Touch Screen Drivers for Dialog da9052

[Trilok Soni]

Adding linux-input mailing list.

On Fri, Feb 26, 2010 at 6:06 PM, Nitin Shah <Nitin.Shah@kpitcummins.com> wrote:
> Hi,
>
> We have developed Touch Screen (TSI) Drivers for Dialog da9052 Power Management IC.
>
> We have tested this driver on Samsung SMDK-6410 board. If any one needs test application tor testing this driver, we will provide the same which we have used for testing.
>
> For more details about the attached drives please refer the README file inside "da9052_drivers.zip".
>
> We would like to incorporate this driver into Linux mainline kernel.
>
> Please test the driver and provide your valuable comments and feedback.

Please don't send .zip files. It would be nice if you can send inline
patches to linux-input ML. Please refer Documentation directory for
instructions on submitting patches.


-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

Re: Touch Screen Drivers for Dialog da9052

[Jonathan Cameron]

On 02/26/10 12:36, Nitin Shah wrote:
> Hi,
> 
> We have developed Touch Screen (TSI) Drivers for Dialog da9052 Power
> Management IC.
> 
> We have tested this driver on Samsung SMDK-6410 board. If any one
> needs test application tor testing this driver, we will provide the
> same which we have used for testing.
> 
> For more details about the attached drives please refer the README
> file inside "da9052_drivers.zip".
> 
> We would like to incorporate this driver into Linux mainline kernel.
> 
> Please test the driver and provide your valuable comments and
> feedback.
> 
> Thanks & Regards, Nitin Shah
Hi Nitin,

Couple of initial points.  Please take a look at the guidance on
Submitting patches in the Documentation directory of the linux
kernel source tree. To get more eyes on code you need to make it
as simple as possible for people to take a look!

To move this driver set towards merging, take a look at how the other
da90xx chips are handled in the current kernel.  Given the chips have
a lot of different functionality fitting into numerous corners of the
kernel, that a given user may or may not want to use, they are implemented
as multifunction devices (drivers/mfd) with children in a number of other
subsystems.

Whilst the code you have sent is pretty clear and well commented etc, it
is going to need a lot of changes to interface with the relevant kernel
subsystems.

Perhaps this is one for staging? 

I've cc'd in a few other relevant people to bring it to their attention.
Note all, while the email only mentioned touch screen drivers, this a pretty
comprehensive pmic driver with tsi, adc, gpio, regulator control and various
other bits and bobs.

Jonathan

Re: Touch Screen Drivers for Dialog da9052

[Greg KH]

On Fri, Feb 26, 2010 at 01:38:44PM +0000, Jonathan Cameron wrote:
> On 02/26/10 12:36, Nitin Shah wrote:
> > Hi,
> > 
> > We have developed Touch Screen (TSI) Drivers for Dialog da9052 Power
> > Management IC.
> > 
> > We have tested this driver on Samsung SMDK-6410 board. If any one
> > needs test application tor testing this driver, we will provide the
> > same which we have used for testing.
> > 
> > For more details about the attached drives please refer the README
> > file inside "da9052_drivers.zip".
> > 
> > We would like to incorporate this driver into Linux mainline kernel.
> > 
> > Please test the driver and provide your valuable comments and
> > feedback.
> > 
> > Thanks & Regards, Nitin Shah
> Hi Nitin,
> 
> Couple of initial points.  Please take a look at the guidance on
> Submitting patches in the Documentation directory of the linux
> kernel source tree. To get more eyes on code you need to make it
> as simple as possible for people to take a look!
> 
> To move this driver set towards merging, take a look at how the other
> da90xx chips are handled in the current kernel.  Given the chips have
> a lot of different functionality fitting into numerous corners of the
> kernel, that a given user may or may not want to use, they are implemented
> as multifunction devices (drivers/mfd) with children in a number of other
> subsystems.
> 
> Whilst the code you have sent is pretty clear and well commented etc, it
> is going to need a lot of changes to interface with the relevant kernel
> subsystems.
> 
> Perhaps this is one for staging? 

I'll take anything for staging, it just has to build and be
self-contained and have someone who is working on getting it merged to
the main kernel tree.

thanks,

greg k-h