From: Evgeniy Polyakov <zbr@ioremap.net>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Why does connector use a work queue???
Date: Sun, 28 Feb 2010 22:52:43 +0300 [thread overview]
Message-ID: <20100228195243.GA15976@ioremap.net> (raw)
In-Reply-To: <m1pr3qcbk1.fsf@fess.ebiederm.org>
On Sat, Feb 27, 2010 at 06:57:02PM -0800, Eric W. Biederman (ebiederm@xmission.com) wrote:
> These days netlink callbacks for messages happen in the context of the
> process who sent the message. Things like permission checks are much
> more complicated if we don't use that process context.
>
> I was looking at removing NETLINK_CB(skb).eff_cap but I discovered
> that connected takes the netlink messages, them from their
> perfectly good process context, and puts the into a workqueue
> for reasons that are not apparent to me.
Netlink was made synchronous rather recently and connector was not
changed to take advantage of that. Previously it used work queue to
postpone work processing into always-process context.
> Unless I am misreading something we should just be able to remove the
> work queues and greatly simplify the connector code.
>
> Something like:
Idea looks very good, thank you, but it misses structure changes
to eliminate now unneded members.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2010-02-28 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 2:57 Why does connector use a work queue??? Eric W. Biederman
2010-02-28 19:52 ` Evgeniy Polyakov [this message]
2010-02-28 20:10 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100228195243.GA15976@ioremap.net \
--to=zbr@ioremap.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox