Re: [RESEND PATCH 2/2] serial: Add driver for the Altera UART

[Tobias Klauser <tklauser@distanz.ch>]

On 2010-02-26 at 20:50:22 +0100, Dan Carpenter <error27@gmail.com> wrote:
> A couple smatch complaints.
> 
> drivers/serial/altera_jtaguart.c
>    380          if (co->index >= 0 && co->index <= ALTERA_JTAGUART_MAXPORTS)
>    381                  co->index = 0;
>    382          port = &altera_jtaguart_ports[co->index].port;
> 
> This test seems backward.  co->index == -1 would be a buffer underflow.
> 
> drivers/serial/altera_uart.c
>    455          if ((co->index >= 0)
>    456              && (co->index <= CONFIG_SERIAL_ALTERA_UART_MAXPORTS))
>    457                  co->index = 0;
>    458          port = &altera_uart_ports[co->index].port;
> 
> Same here.

Yep, those look completely wrong. I'll post an updated patch (including
the other changes suggested by Alan and Peter) later on.

Thanks,
Tobias