From: Andres Salomon <dilinger@collabora.co.uk>
To: Ben Gardner <gardner.ben@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input
Date: Mon, 1 Mar 2010 10:17:21 -0500 [thread overview]
Message-ID: <20100301101721.6cd30f9b@droptest.queued.net> (raw)
In-Reply-To: <808c8e9d1003010655m4f31f3c2wcbe0c1c882ab202e@mail.gmail.com>
On Mon, 1 Mar 2010 08:55:44 -0600
Ben Gardner <gardner.ben@gmail.com> wrote:
> > Lets see how the proposed changes I just sent off are received and go
> > from there.
>
> Based on the feedback from the other gpio patches, I'd like to do the following:
> 1) drop this patch (olpc-alsa-fix-cs5535audios-mic-gpio-to-enable-input.patch)
> 2) drop the patch that caused this patch to be created
> (cs5535_gpio-gpio_chipget-should-return-the-input-value.patch)
> 3) submit a new patch that contains the original change + the changes
> needed to adjust input/output settings to follow the spirit of
> gpiolib.
>
> That way, there is one patch that fully fixes the issue and no window
> where the OLPC MIC stuff is broken.
>
That'd be great, thanks!
prev parent reply other threads:[~2010-03-01 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 22:55 [PATCH] cs5535_gpio: gpio_chip.get should return the input value Ben Gardner
2010-02-24 22:58 ` Andrew Morton
2010-02-25 3:52 ` Ben Gardner
2010-02-25 4:05 ` Andrew Morton
2010-02-25 4:16 ` Ben Gardner
2010-02-25 5:04 ` Andres Salomon
2010-02-24 23:42 ` Andres Salomon
2010-02-24 23:45 ` [PATCH] OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input Andres Salomon
2010-02-26 17:47 ` Ben Gardner
2010-02-26 21:07 ` Andres Salomon
2010-02-26 23:32 ` Ben Gardner
2010-03-01 14:55 ` Ben Gardner
2010-03-01 15:17 ` Andres Salomon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301101721.6cd30f9b@droptest.queued.net \
--to=dilinger@collabora.co.uk \
--cc=akpm@linux-foundation.org \
--cc=gardner.ben@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox