From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] KVM: SVM: Use svm_msrpm_offset in nested_svm_exit_handled_msr
Date: Mon, 1 Mar 2010 14:33:46 +0100 [thread overview]
Message-ID: <20100301133346.GD31544@amd.com> (raw)
In-Reply-To: <4B87A2D0.2040605@redhat.com>
On Fri, Feb 26, 2010 at 12:30:40PM +0200, Avi Kivity wrote:
> On 02/25/2010 07:15 PM, Joerg Roedel wrote:
> >There is a generic function now to calculate msrpm offsets.
> >Use that function in nested_svm_exit_handled_msr() remove
> >the duplicate logic.
> >
>
> Hm, if the function would also calculate the mask, then it would be
> useful for set_msr_interception() as well.
The set_msr_interception is the only caller which need this mask. I
prefer to let this calculation there. The msrpm merge function only
needs the offset.
Joerg
next prev parent reply other threads:[~2010-03-01 13:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 17:15 [PATCH 0/5] Rework of msrpm optimization and additional fixes for nested svm Joerg Roedel
2010-02-25 17:15 ` [PATCH 1/5] KVM: SVM: Move msrpm offset calculation to seperate function Joerg Roedel
2010-02-26 10:20 ` Avi Kivity
2010-02-26 10:25 ` Joerg Roedel
2010-02-25 17:15 ` [PATCH 2/5] KVM: SVM: Optimize nested svm msrpm merging Joerg Roedel
2010-02-26 10:28 ` Avi Kivity
2010-02-26 12:25 ` Joerg Roedel
2010-02-26 12:28 ` Alexander Graf
2010-02-26 13:04 ` Joerg Roedel
2010-02-26 13:08 ` Alexander Graf
2010-02-26 13:19 ` Joerg Roedel
2010-02-26 13:10 ` Avi Kivity
2010-02-26 13:21 ` Joerg Roedel
2010-02-26 13:26 ` Alexander Graf
2010-02-26 13:30 ` Joerg Roedel
2010-02-26 13:59 ` Avi Kivity
2010-02-26 12:42 ` Avi Kivity
2010-02-25 17:15 ` [PATCH 3/5] KVM: SVM: Use svm_msrpm_offset in nested_svm_exit_handled_msr Joerg Roedel
2010-02-26 10:30 ` Avi Kivity
2010-03-01 13:33 ` Joerg Roedel [this message]
2010-02-25 17:15 ` [PATCH 4/5] KVM: SVM: Add correct handling of nested iopm Joerg Roedel
2010-02-26 10:33 ` Avi Kivity
2010-02-25 17:15 ` [PATCH 5/5] KVM: SVM: Ignore lower 12 bit of nested msrpm_pa Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301133346.GD31544@amd.com \
--to=joerg.roedel@amd.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox