Re: tip: origin tree boot crash

Ingo Molnar
2010-03-04T03:01:15Z

* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Mon, Mar 01, 2010 at 03:55:19PM +0100, Steffen Klassert wrote:
> >
> > On Mon, Mar 01, 2010 at 08:50:24AM +0100, Ingo Molnar wrote:
> > >
> > > * Herbert Xu <herbert@gondor.apana.org.au> wrote:
> > >
> > > > crypto: pcrypt - Add pcrypt crypto parallelization wrapper
> > >
> > > -tip testing started triggering the following frequent boot crash yesterday,
> > > on 64-bit x86:
> > >
> > > | calling pcrypt_init+0x0/0xee @ 1
> > > | BUG: unable to handle kernel NULL pointer dereference at (null)
> > > | IP: [<ffffffff8126550b>] memcpy+0xb/0xb0
> > > | Call Trace:
> > > | [<ffffffff810c2f38>] ? padata_alloc+0x98/0x150
> > > | [<ffffffff82158c51>] ? pcrypt_init+0x0/0xee
> > > | [<ffffffff82158ccc>] pcrypt_init+0x7b/0xee
> > >
> >
> > Ugh, it seems that I forgot to allocate one of the cpumasks. Looking at the
> > configs of my test systems I noticed, that CONFIG_CPUMASK_OFFSTACK was
> > not set on all the configs, so I did not notice it.
> >
> > The patch below fixes the boot crash if CONFIG_CPUMASK_OFFSTACK is
> > enabled on my test systems. Does the patch fix it for you too?
>
> Ingo, any luck with this patch from Steffen?

I'm still busy with the merge window - please dont wait for me and consider it
fixed, i'll re-report if there's still any problems.

Thanks,

Ingo