Re: Crypto Fixes for 3.12

Herbert Xu
2013-09-13T14:39:17Z

On Fri, Sep 13, 2013 at 07:22:55AM -0700, Linus Torvalds wrote:
> On Fri, Sep 13, 2013 at 4:30 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > Herbert Xu (2):
> > crypto: api - Fix race condition in larval lookup
> > crypto: crct10dif - Add fallback for broken initrds
> >
> > crypto/Makefile | 2 +-
> > crypto/api.c | 7 +-
> > crypto/{crct10dif.c => crct10dif_common.c} | 100 +--------------------------
> > crypto/{crct10dif.c => crct10dif_generic.c} | 53 +-------------
> > lib/crc-t10dif.c | 11 ++-
> > 5 files changed, 20 insertions(+), 153 deletions(-)
>
> Please fix your script. You apparently have it using "-C" to find
> copies, which can be very useful to see what is going on especially
> with "--summary" (which you don't have), but is misleading when
> sending diffstats when people don't expect it.

Sorry, will do for future pushes. FWIW the -M stats are

crypto/Makefile | 2 +-
crypto/api.c | 7 +-
crypto/{crct10dif.c => crct10dif_common.c} | 100 +---------------------
crypto/crct10dif_generic.c | 127 ++++++++++++++++++++++++++++
lib/crc-t10dif.c | 11 ++-
5 files changed, 146 insertions(+), 101 deletions(-)

> With just rename detection (git diff -M --stat --summary)
> crypto/Makefile | 2 +-
> crypto/api.c | 7 +-
> crypto/{crct10dif.c => crct10dif_common.c} | 100 +---------------
> crypto/crct10dif_generic.c | 127 +++++++++++++++++++++
> lib/crc-t10dif.c | 11 +-
> 5 files changed, 146 insertions(+), 101 deletions(-)
> rename crypto/{crct10dif.c => crct10dif_common.c} (63%)
> create mode 100644 crypto/crct10dif_generic.c