Re: Crypto Fixes for 3.12

Linus Torvalds
2013-09-13T14:22:58Z

On Fri, Sep 13, 2013 at 4:30 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Herbert Xu (2):
> crypto: api - Fix race condition in larval lookup
> crypto: crct10dif - Add fallback for broken initrds
>
> crypto/Makefile | 2 +-
> crypto/api.c | 7 +-
> crypto/{crct10dif.c => crct10dif_common.c} | 100 +--------------------------
> crypto/{crct10dif.c => crct10dif_generic.c} | 53 +-------------
> lib/crc-t10dif.c | 11 ++-
> 5 files changed, 20 insertions(+), 153 deletions(-)

Please fix your script. You apparently have it using "-C" to find
copies, which can be very useful to see what is going on especially
with "--summary" (which you don't have), but is misleading when
sending diffstats when people don't expect it.

The pull request does not have "20 insertions", it has "146
insertions", and it's just that a fair chunk of them come from a file
being essentially duplicated. See the difference:

With copy detection ("git diff -C --stat --summary")
crypto/Makefile | 2 +-
crypto/api.c | 7 +-
crypto/{crct10dif.c => crct10dif_common.c} | 100 +-------------------
crypto/{crct10dif.c => crct10dif_generic.c} | 53 +----------
lib/crc-t10dif.c | 11 ++-
5 files changed, 20 insertions(+), 153 deletions(-)
copy crypto/{crct10dif.c => crct10dif_common.c} (63%)
rename crypto/{crct10dif.c => crct10dif_generic.c} (55%)

With just rename detection (git diff -M --stat --summary)
crypto/Makefile | 2 +-
crypto/api.c | 7 +-
crypto/{crct10dif.c => crct10dif_common.c} | 100 +---------------
crypto/crct10dif_generic.c | 127 +++++++++++++++++++++
lib/crc-t10dif.c | 11 +-
5 files changed, 146 insertions(+), 101 deletions(-)
rename crypto/{crct10dif.c => crct10dif_common.c} (63%)
create mode 100644 crypto/crct10dif_generic.c

and your pull request looked really misleading because it did "-C" but
didn't have that summary pointing out that one of them was a copy.

So please use "-M --stat --summary". That's what git shows me when I
do a "git pull", so that's what I'm going to compare with..

As mentioned "-C" _is_ useful, but it's useful when you're
specifically looking for "that's a lot of new lines, is it copying old
files" kind of things.

Linus