From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: James Cloos <cloos@jhcloos.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, zippel@linux-m68k.org,
mingo@elte.hu, akpm@linux-foundation.org
Subject: Re: [PATCH RFC] kconfig: place git SHA1 in .config output if in git tree
Date: Mon, 1 Mar 2010 21:21:42 -0800 [thread overview]
Message-ID: <20100302052142.GA6821@linux.vnet.ibm.com> (raw)
In-Reply-To: <m3d3zn4hg8.fsf@lugabout.jhcloos.org>
On Mon, Mar 01, 2010 at 08:53:19PM -0500, James Cloos wrote:
> >>>>> "Paul" == Paul E McKenney <paulmck@linux.vnet.ibm.com> writes:
>
> Paul> Agreed! The "-dirty" modifier for the case of changes not yet
> Paul> checked into git looks especially helpful.
>
> JimC> Except that the script calls »git update-index --refresh --unmerged«
> JimC> and »git diff-index --name-only HEAD«, both of which are painfully
> JimC> slow and resource intensive.
>
> JimC> I'd hate to have that run every time I make a kernel.
>
> Paul> Good point... Should we have an environment variable that controls
> Paul> this behavior?
>
> I wouldn't mind the intial idea: just the abbreviated top of three hash.
>
> I was, next, going to write that CONFIG_LOCALVERSION_AUTO already exists
> for that, but LOCALVERSION_AUTO calls scripts/setlocalversion these days
> and that is what I'd prefer to avoid. [SIGH]
>
> Shows how long it has been since I last used it. I stopped using it
> when I was maintaining my .config in git. Now I maintain .config in a
> separate git repo, for the express purpose of avoiding a merge (rather
> than a fast forward) when I run git pull. Something that a local edit
> of scripts/setlocalversion will, of course, prevent.
>
> Anyone up for a CONFIG_LOCALVERSION_AUTO_DO_NOT_BOTHER_WITH_DIRTY? ☺
It looks like it would be pretty easy to make make scripts/setlocalversion
look at an environment variable to decide whether or not to do the index
update and the check for uncommitted changes. Default would seem to
need to be to do it the slow way.
Or would that cause other problems?
Thanx, Paul
prev parent reply other threads:[~2010-03-02 5:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 4:22 [PATCH RFC] kconfig: place git SHA1 in .config output if in git tree Paul E. McKenney
2010-03-01 8:34 ` Ingo Molnar
2010-03-01 9:42 ` Frans Pop
2010-03-01 10:10 ` Geert Uytterhoeven
2010-03-01 16:27 ` Paul E. McKenney
2010-03-01 16:53 ` Frans Pop
2010-03-01 18:16 ` Paul E. McKenney
2010-03-01 20:29 ` Frans Pop
2010-03-02 1:16 ` Paul E. McKenney
2010-03-02 15:19 ` Frans Pop
2010-03-03 0:01 ` Paul E. McKenney
2010-03-03 0:42 ` Frans Pop
2010-03-03 2:19 ` Paul E. McKenney
2010-03-01 16:22 ` Linus Torvalds
2010-03-01 16:48 ` Paul E. McKenney
2010-03-01 20:46 ` James Cloos
2010-03-02 1:20 ` Paul E. McKenney
2010-03-02 1:53 ` James Cloos
2010-03-02 5:21 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302052142.GA6821@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cloos@jhcloos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox