From: Ingo Molnar <mingo@elte.hu>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Peter Osterlund <petero2@telia.com>,
Jens Axboe <jens.axboe@oracle.com>,
Akinobu Mita <akinobu.mita@gmail.com>
Subject: Re: [PATCH -next] pktcdvd: improve BKL and compat_ioctl.c usage
Date: Tue, 2 Mar 2010 13:06:21 +0100 [thread overview]
Message-ID: <20100302120621.GA28192@elte.hu> (raw)
In-Reply-To: <4B86F564.9000105@oracle.com>
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On 02/25/10 13:27, Arnd Bergmann wrote:
> > The pktcdvd driver uses proper locking and does not need the
> > BKL in the ioctl and llseek functions of the character device,
> > so kill both. Moving the compat_ioctl handling from common code
> > into the driver itself fixes build problems when CONFIG_BLOCK is
> > disabled.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > ---
> > On Thursday 25 February 2010, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> fs/compat_ioctl.c should omit pktcdvd.h and its ioctl when CONFIG_BLOCK
> >> is not enabled. This fixes these build errors:
> >>
> >> In file included from fs/compat_ioctl.c:105:
> >> include/linux/pktcdvd.h:166: error: field 'read_queue' has incomplete type
> >> include/linux/pktcdvd.h:167: error: field 'write_queue' has incomplete type
> >> include/linux/pktcdvd.h:207: error: field 'orig_bios' has incomplete type
> >> make[2]: *** [fs/compat_ioctl.o] Error 1
> >
> > How about this one instead, cleaning pktcdvd ioctl handling up for good?
>
> OK, that works too.
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
FYI, this build bug now triggers upstream too - none of the fixes was applied.
Ingo
next prev parent reply other threads:[~2010-03-02 12:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 7:35 linux-next: Tree for February 25 Stephen Rothwell
2010-02-25 17:21 ` linux-next: Tree for February 25 (quota) Randy Dunlap
2010-03-01 13:27 ` Jan Kara
2010-03-01 16:56 ` Randy Dunlap
2010-02-25 17:55 ` [PATCH -next] staging: fix wlan-ng printk format warning Randy Dunlap
2010-02-25 17:55 ` [PATCH -next] fs: fix compat_ioctl when CONFIG_BLOCK=n Randy Dunlap
2010-02-25 21:27 ` [PATCH -next] pktcdvd: improve BKL and compat_ioctl.c usage Arnd Bergmann
2010-02-25 22:10 ` Randy Dunlap
2010-03-02 12:06 ` Ingo Molnar [this message]
2010-03-02 23:38 ` Stephen Rothwell
2010-02-25 22:41 ` [PATCH -next] staging/pohmelfs: fix write_inode parameter warning Randy Dunlap
2010-02-26 0:41 ` Stephen Rothwell
2010-03-07 9:22 ` Geert Uytterhoeven
2010-03-07 15:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302120621.GA28192@elte.hu \
--to=mingo@elte.hu \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=petero2@telia.com \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox