From: Ingo Molnar <mingo@elte.hu>
To: Matthew Garrett <mjg@redhat.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [PATCH] compal-laptop: Make it depend on CONFIG_RFKILL
Date: Tue, 2 Mar 2010 14:56:26 +0100 [thread overview]
Message-ID: <20100302135626.GA18373@elte.hu> (raw)
In-Reply-To: <1267197527-18062-1-git-send-email-mjg@redhat.com>
Hi,
* Matthew Garrett <mjg@redhat.com> wrote:
> compal-laptop: Add support for known Compal made Dell laptops
> compal-laptop: Replace sysfs support with rfkill support
FYI, -tip testing found a (relatively rare) build failure introduced by these
commits, which occurs with certain .config's - see the fix below. Please
apply.
Thanks,
Ingo
--------------------------->
>From a6e5fbf2d4b6e9f78abcc5784f23403aa7972369 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Tue, 2 Mar 2010 14:51:16 +0100
Subject: [PATCH] compal-laptop: Make it depend on CONFIG_RFKILL
-tip testing found this build failure (x86 randconfig):
drivers/built-in.o: In function `setup_rfkill':
compal-laptop.c:(.text+0x36abe8): undefined reference to `rfkill_alloc'
compal-laptop.c:(.text+0x36abfc): undefined reference to `rfkill_register'
compal-laptop.c:(.text+0x36ac30): undefined reference to `rfkill_alloc'
compal-laptop.c:(.text+0x36ac44): undefined reference to `rfkill_register'
Which can happen with CONFIG_COMPAL_LAPTOP=y but COMPAL_LAPTOP=m.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/platform/x86/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 89da3e2..56076ee 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -178,6 +178,7 @@ config COMPAL_LAPTOP
tristate "Compal Laptop Extras"
depends on ACPI
depends on BACKLIGHT_CLASS_DEVICE
+ depends on RFKILL
---help---
This is a driver for laptops built by Compal:
prev parent reply other threads:[~2010-03-02 13:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 15:18 [GIT PULL] x86 platform drivers tree Matthew Garrett
2010-02-26 15:18 ` [PATCH 01/14] MAINTAINERS: update drivers/platform/x86 information Matthew Garrett
2010-02-26 16:18 ` Thadeu Lima de Souza Cascardo
2010-02-26 16:39 ` Anisse Astier
2010-02-26 16:44 ` Anisse Astier
2010-02-26 23:58 ` Henrique de Moraes Holschuh
2010-02-26 21:53 ` Corentin Chary
2010-03-01 17:59 ` Len Brown
2010-03-01 18:02 ` Matthew Garrett
2010-03-01 18:23 ` Len Brown
2010-02-26 23:51 ` Peter Feuerer
2010-02-27 3:42 ` Jonathan Woithe
2010-02-27 4:39 ` Harald Welte
2010-02-26 15:18 ` [PATCH 02/14] compal-laptop: Add support for known Compal made Dell laptops Matthew Garrett
2010-02-26 15:18 ` [PATCH 03/14] compal-laptop: Replace sysfs support with rfkill support Matthew Garrett
2010-02-26 15:18 ` [PATCH 04/14] dell-laptop: Update rfkill state on kill switch Matthew Garrett
2010-02-27 8:06 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 05/14] dell-laptop: Fix platform device unregistration Matthew Garrett
2010-02-27 8:09 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 06/14] dell-laptop: Fix small memory leak Matthew Garrett
2010-02-26 15:18 ` [PATCH 07/14] dell-laptop: Block software state changes when rfkill hard blocked Matthew Garrett
2010-02-26 15:18 ` [PATCH 08/14] dell-laptop: Blacklist machines not supporting dell-laptop Matthew Garrett
2010-02-26 15:18 ` [PATCH 09/14] dell-laptop: Use buffer with 32-bit physical address Matthew Garrett
2010-02-27 8:11 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 10/14] dell-laptop: Pay attention to which devices the hardware switch controls Matthew Garrett
2010-02-26 15:18 ` [PATCH 11/14] classmate-laptop: use a single MODULE_DEVICE_TABLE to get correct aliases Matthew Garrett
2010-02-26 15:18 ` [PATCH 12/14] dell-laptop: Add another Dell laptop to the DMI whitelist Matthew Garrett
2010-02-26 15:18 ` [PATCH 13/14] hp-wmi: Add support for tablet rotation key Matthew Garrett
2010-02-27 8:12 ` Dmitry Torokhov
2010-02-26 15:18 ` [PATCH 14/14] toshiba_acpi: Add full hotkey support Matthew Garrett
2010-02-27 0:07 ` [GIT PULL] x86 platform drivers tree Henrique de Moraes Holschuh
2010-03-01 14:45 ` Matthew Garrett
2010-02-28 19:59 ` tip: origin tree build failure Ingo Molnar
2010-03-02 13:56 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302135626.GA18373@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox