[PATCH 1/1] perf archive: Don't try to collect files without a build-id

[PATCH 1/1] perf archive: Don't try to collect files without a build-id

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

To avoid these error:

   [root@doppio ~]# perf archive
   tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
   No such file or directory
   tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
   No such file or directory
   tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
   No such file or directory
   tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
   No such file or directory
   tar: Exiting with failure status due to previous errors
   [root@doppio ~]#

More work is needed to support archiving symtabs for binaries without a
build-id, perhaps creating a perf.data UUID + adding build-ids for the
binaries copied into the cache and then have this perf.data session UUID
be a directory with symlinks to the by now calculated build-id of the
files inside it.

Or just do an extra pass and insert the calculated build-ids in the
perf.data header.

Reported-by: Ingo Molnar <mingo@elte.hu>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/perf-archive.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/perf/perf-archive.sh b/tools/perf/perf-archive.sh
index 45fbe2f..910468e 100644
--- a/tools/perf/perf-archive.sh
+++ b/tools/perf/perf-archive.sh
@@ -9,8 +9,9 @@ fi
 
 DEBUGDIR=~/.debug/
 BUILDIDS=$(mktemp /tmp/perf-archive-buildids.XXXXXX)
+NOBUILDID=0000000000000000000000000000000000000000
 
-perf buildid-list -i $PERF_DATA --with-hits > $BUILDIDS
+perf buildid-list -i $PERF_DATA --with-hits | grep -v "^$NOBUILDID " > $BUILDIDS
 if [ ! -s $BUILDIDS ] ; then
 	echo "perf archive: no build-ids found"
 	rm -f $BUILDIDS
-- 
1.6.2.5

Re: [PATCH 1/1] perf archive: Don't try to collect files without a build-id

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> To avoid these error:
> 
>    [root@doppio ~]# perf archive
>    tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
>    No such file or directory
>    tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
>    No such file or directory
>    tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
>    No such file or directory
>    tar: .build-id/00/00000000000000000000000000000000000000: Cannot stat:
>    No such file or directory
>    tar: Exiting with failure status due to previous errors
>    [root@doppio ~]#

Your fix solved the problem on my box too - thanks!

	Ingo