Re: [GIT PULL] x86/mm fixes

Wu Fengguang
2010-03-04T00:44:40Z

On Thu, Mar 04, 2010 at 01:10:46AM +0800, Linus Torvalds wrote:
>
>
> On Wed, 3 Mar 2010, Wu Fengguang wrote:
> >
> > Anyway I just hacked /usr/share/quilt/refresh to automatically run the
> > kernel style checker:
> >
> > # wfg: check for kernel coding style
> > if [ -x scripts/checkpatch.pl ]; then
> > scripts/checkpatch.pl $patch_file
> > fi
>
> It's probably sensible to check things, but do remember that some of the
> things checkpatch warns about are better left the way they are, rather
> than make the code uglier just to make checkpatch happy.

OK. Here is the simple patch for quilt. I guess it may be hardly
acceptable for quilt upstream, so only intends to share it here.

Thanks,
Fengguang
---

--- /usr/share/quilt/refresh.orig 2010-03-04 08:38:27.000000000 +0800
+++ /usr/share/quilt/refresh 2010-03-04 08:38:29.000000000 +0800
@@ -265,6 +265,12 @@ fi

patch_file=$(patch_file_name $patch)

+# check for kernel coding style
+# Linus: please treat its warning as recommendation instead of requirement
+if [ -x scripts/checkpatch.pl ]; then
+ scripts/checkpatch.pl -q $patch_file
+fi
+
trap "" SIGINT

tmp_result=$(gen_tempfile) || die 1