From: Ed Cashin <ecashin@coraid.com>
To: Tejun Heo <tj@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>, taeuber@bbaw.de
Subject: Re: aoeblk_make_request() chokes on zero-length barriers
Date: Wed, 3 Mar 2010 10:30:15 -0500 [thread overview]
Message-ID: <20100303153015.GD3268@coraid.com> (raw)
In-Reply-To: <4B8DE160.5070506@kernel.org>
On Wed, Mar 03, 2010 at 01:11:12PM +0900, Tejun Heo wrote:
> Hello, Ed L. Cashin.
>
> This is reported on openSUSE 11.2 by Lars Tauber on bnc581271[1] but
> upstream code seems to have the same problem. If a bio doesn't have
> bi_io_vec, aoeblk_make_request() triggers BUG() but in recent kernels
> the block layer will happily send down zero-length barrier bios w/o
> bi_io_vec set.
It looks like the opensuse 11.x kernel doesn't have the
change that made aoe return -EOPNOTSUPP for barriers.
It's commit 18d8217bc441630c3c5ec7416c5a65c69e8a0979,
appearing in v2.6.32-rc1.
I have most of a barrier implementation for aoe done
but got sidetracked. I'd welcome any volunteers who
would like to do testing. Please email me directly.
--
Ed Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2010-03-03 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 4:11 aoeblk_make_request() chokes on zero-length barriers Tejun Heo
2010-03-03 15:30 ` Ed Cashin [this message]
2010-03-03 15:56 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100303153015.GD3268@coraid.com \
--to=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=taeuber@bbaw.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox