From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756714Ab0CEBAj (ORCPT ); Thu, 4 Mar 2010 20:00:39 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60421 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754505Ab0CEBAi (ORCPT ); Thu, 4 Mar 2010 20:00:38 -0500 Date: Thu, 4 Mar 2010 17:00:30 -0800 From: Andrew Morton To: Joe Perches , Linus Torvalds , Nick Andrew , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , netdev@vger.kernel.org Subject: Re: [PATCH 2/2] device.h drivers/base/core.c Convert dev_ macros to functions Message-Id: <20100304170030.f97c6630.akpm@linux-foundation.org> In-Reply-To: <20100304165609.20849b93.akpm@linux-foundation.org> References: <20100304165609.20849b93.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Mar 2010 16:56:09 -0800 Andrew Morton wrote: > On Wed, 3 Mar 2010 22:27:23 -0800 Joe Perches wrote: > > > Save ~60k in a defconfig > > > > Use %pV and struct va_format > > Format arguments are verified before printk > > Well that doesn't work very well. > > drivers/net/pcmcia/pcnet_cs.c:117: error: 'dev_info' redeclared as different kind of symbol > include/linux/device.h:645: error: previous declaration of 'dev_info' was here > > there are lots of other dev_info's which will fail plus perhaps > dev_err's, etc. > btw, this may be kludgeable aroundable by doing int _dev_info(const struct device *dev, const char *fmt, ...); #define dev_info(...) _dev_info(...) which will use the preprocessor's separation of `foo' from `foo()' to fix things up. But it would be better to rename all those dev_info's to device_info or whatever, IMO.