From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932296Ab0CDTnT (ORCPT ); Thu, 4 Mar 2010 14:43:19 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:41739 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932121Ab0CDTnR (ORCPT ); Thu, 4 Mar 2010 14:43:17 -0500 Date: Thu, 4 Mar 2010 20:42:41 +0100 From: Sascha Hauer To: Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= Cc: Guennadi Liakhovetski , Linux Media Mailing List , linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , Antonio Ospite , Hans Verkuil , linux-kernel@vger.kernel.org Subject: Re: [PATCH] V4L/DVB: mx1-camera: compile fix Message-ID: <20100304194241.GG19843@pengutronix.de> References: <1267721687-19697-1-git-send-email-u.kleine-koenig@pengutronix.de> <20100304192623.GA14587@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100304192623.GA14587@pengutronix.de> X-Sent-From: Pengutronix Entwicklungszentrum Nord - Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Impressum: Pengutronix - Industrial Linux Solutions Handelsregister: Amtsgericht Hildesheim, HRA 2686 Peiner Strasse 6-8, 31137 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-5555 Inhaber: Dipl.-Ing. Robert Schwebel X-Message-Flag: See Message Headers for Impressum X-Uptime: 20:38:24 up 143 days, 8:27, 65 users, load average: 1.75, 0.87, 0.76 User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 04, 2010 at 08:26:23PM +0100, Uwe Kleine-König wrote: > Hi Guennadi, > > On Thu, Mar 04, 2010 at 06:13:38PM +0100, Guennadi Liakhovetski wrote: > > > +#undef DMA_BASE > > > +#define DMA_BASE MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) > > > > I don't like this. Why the "undef"? Is DMA_BASE already defined? where and > > what is it? If it is - we better use a different name, if not - just > > remove the undef, please. > yes, it's not pretty, but I wanted to make a minimal patch. > > arch/arm/plat-mxc/include/mach/dma-mx1-mx2.h has: > > #define DMA_BASE IO_ADDRESS(DMA_BASE_ADDR) This is only used in the mx1 camera driver, so you can just remove it from dma-mx1-mx2.h and use MX1_IO_ADDRESS(MX1_DMA_BASE_ADDR) in the camera driver. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |