From: Borislav Petkov <borislav.petkov@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Langsdorf <mark.langsdorf@amd.com>,
<linux-kernel@vger.kernel.org>, <cpufreq@vger.kernel.org>,
<bhavna.sarathy@amd.com>, <joachim.deguara@amd.com>
Subject: Re: [PATCH 3/3] cpufreq: add sysfs knob for toggling core performance boost
Date: Thu, 4 Mar 2010 22:49:21 +0100 [thread overview]
Message-ID: <20100304214921.GB29002@aftab> (raw)
In-Reply-To: <20100304132743.e2b731da.akpm@linux-foundation.org>
From: Andrew Morton <akpm@linux-foundation.org>
Date: Thu, Mar 04, 2010 at 01:27:43PM -0800
> The lack of any changelog in a patch is usually a good sign that the
> patch needs a changelog :(
See my earlier mail.
[..]
> Well I've read the code and I've read the code comments and I've read
> the changelogs and I still have no clue what this thing does.
> Apparently it allows me to toggle something called "APERF/MPERF". I
> guess if I were patient enough, teh goog might tell me what that is,
> and why I might want it. But this is all terribly inefficient.
>
> I think you'd find that your feature is more useful and will be used by
> more people if you tell them (and us) what it does.
Basically, this is a knob for toggling of a core boosting feature
we have in Fam10h, rev.E CPUs. I'll have a proper changelog with a
hopefully understandable explanation soon :).
Thanks.
--
Regards/Gruss,
Boris.
-
Advanced Micro Devices, Inc.
Operating Systems Research Center
prev parent reply other threads:[~2010-03-04 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 20:59 [PATCH 3/3] cpufreq: add sysfs knob for toggling core performance boost Mark Langsdorf
2010-03-04 21:27 ` Andrew Morton
2010-03-04 21:49 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304214921.GB29002@aftab \
--to=borislav.petkov@amd.com \
--cc=akpm@linux-foundation.org \
--cc=bhavna.sarathy@amd.com \
--cc=cpufreq@vger.kernel.org \
--cc=joachim.deguara@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox