From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755832Ab0CEWfZ (ORCPT ); Fri, 5 Mar 2010 17:35:25 -0500 Received: from trinity.develer.com ([83.149.158.210]:54761 "EHLO trinity.develer.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754740Ab0CEWfY (ORCPT ); Fri, 5 Mar 2010 17:35:24 -0500 Date: Fri, 5 Mar 2010 23:35:20 +0100 From: Andrea Righi To: Balbir Singh Cc: KAMEZAWA Hiroyuki , Vivek Goyal , Peter Zijlstra , Trond Myklebust , Suleiman Souhlal , Greg Thelen , Daisuke Nishimura , "Kirill A. Shutemov" , Andrew Morton , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -mmotm 2/4] page_cgroup: introduce file cache flags Message-ID: <20100305223519.GC1578@linux> References: <1267699215-4101-1-git-send-email-arighi@develer.com> <1267699215-4101-3-git-send-email-arighi@develer.com> <20100305063249.GH3073@balbir.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100305063249.GH3073@balbir.in.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2010 at 12:02:49PM +0530, Balbir Singh wrote: > * Andrea Righi [2010-03-04 11:40:13]: > > > Introduce page_cgroup flags to keep track of file cache pages. > > > > Signed-off-by: KAMEZAWA Hiroyuki > > Signed-off-by: Andrea Righi > > --- > > Looks good > > > Acked-by: Balbir Singh > > > > include/linux/page_cgroup.h | 49 +++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 49 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/page_cgroup.h b/include/linux/page_cgroup.h > > index 30b0813..1b79ded 100644 > > --- a/include/linux/page_cgroup.h > > +++ b/include/linux/page_cgroup.h > > @@ -39,6 +39,12 @@ enum { > > PCG_CACHE, /* charged as cache */ > > PCG_USED, /* this object is in use. */ > > PCG_ACCT_LRU, /* page has been accounted for */ > > + PCG_MIGRATE_LOCK, /* used for mutual execution of account migration */ > > + PCG_ACCT_FILE_MAPPED, /* page is accounted as file rss*/ > > + PCG_ACCT_DIRTY, /* page is dirty */ > > + PCG_ACCT_WRITEBACK, /* page is being written back to disk */ > > + PCG_ACCT_WRITEBACK_TEMP, /* page is used as temporary buffer for FUSE */ > > + PCG_ACCT_UNSTABLE_NFS, /* NFS page not yet committed to the server */ > > }; > > > > #define TESTPCGFLAG(uname, lname) \ > > @@ -73,6 +79,27 @@ CLEARPCGFLAG(AcctLRU, ACCT_LRU) > > TESTPCGFLAG(AcctLRU, ACCT_LRU) > > TESTCLEARPCGFLAG(AcctLRU, ACCT_LRU) > > > > +/* File cache and dirty memory flags */ > > +TESTPCGFLAG(FileMapped, ACCT_FILE_MAPPED) > > +SETPCGFLAG(FileMapped, ACCT_FILE_MAPPED) > > +CLEARPCGFLAG(FileMapped, ACCT_FILE_MAPPED) > > + > > +TESTPCGFLAG(Dirty, ACCT_DIRTY) > > +SETPCGFLAG(Dirty, ACCT_DIRTY) > > +CLEARPCGFLAG(Dirty, ACCT_DIRTY) > > + > > +TESTPCGFLAG(Writeback, ACCT_WRITEBACK) > > +SETPCGFLAG(Writeback, ACCT_WRITEBACK) > > +CLEARPCGFLAG(Writeback, ACCT_WRITEBACK) > > + > > +TESTPCGFLAG(WritebackTemp, ACCT_WRITEBACK_TEMP) > > +SETPCGFLAG(WritebackTemp, ACCT_WRITEBACK_TEMP) > > +CLEARPCGFLAG(WritebackTemp, ACCT_WRITEBACK_TEMP) > > + > > +TESTPCGFLAG(UnstableNFS, ACCT_UNSTABLE_NFS) > > +SETPCGFLAG(UnstableNFS, ACCT_UNSTABLE_NFS) > > +CLEARPCGFLAG(UnstableNFS, ACCT_UNSTABLE_NFS) > > + > > static inline int page_cgroup_nid(struct page_cgroup *pc) > > { > > return page_to_nid(pc->page); > > @@ -83,6 +110,9 @@ static inline enum zone_type page_cgroup_zid(struct page_cgroup *pc) > > return page_zonenum(pc->page); > > } > > > > +/* > > + * lock_page_cgroup() should not be held under mapping->tree_lock > > + */ > > May be a DEBUG WARN_ON would be appropriate here? Sounds good. WARN_ON_ONCE()? Thanks, -Andrea