From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752601Ab0CFJzU (ORCPT ); Sat, 6 Mar 2010 04:55:20 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:47700 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813Ab0CFJzR (ORCPT ); Sat, 6 Mar 2010 04:55:17 -0500 Date: Sat, 6 Mar 2010 04:55:09 -0500 From: Christoph Hellwig To: Al Viro Cc: Linus Torvalds , Jan Kara , LKML , linux-fsdevel@vger.kernel.org, dushistov@mail.ru, joel.becker@oracle.com, shaggy@linux.vnet.ibm.com, linux-ext4@vger.kernel.org Subject: Re: [PULL REQUEST] Quota cleanups & fixes and ext3 fixes for 2.6.34-rc1 Message-ID: <20100306095509.GA23951@infradead.org> References: <20100305003304.GE4887@quack.suse.cz> <20100305230117.GZ30031@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100305230117.GZ30031@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2010 at 11:01:17PM +0000, Al Viro wrote: > I'd say that places where it's added are lousy - if we want to do that > on directory modifications, we ought to take it into places that actually > create directory entries. Not to mention that we never shrink directories > there, so it should be just one call in ext2_add_link() instead of all > that pile. > > Looks like a good case for a followup series, if nothing else. Yes, this will get sorted out per filesystem later, but I didn't want to mess around with all filesystems in one series.