* UML XFS link error list_sort
@ 2010-03-07 2:28 Parag Warudkar
2010-03-07 3:25 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Parag Warudkar @ 2010-03-07 2:28 UTC (permalink / raw)
To: linux-kernel; +Cc: david
Hi Dave
While building today's git for CONFIG_UML, I got a link error (list_sort
undefined) for xfs.ko.
Currently I am working around it with the below hack. Not sure the right
thing to do would be some where at the arch level for UML or if the below
would be appropriate.
Parag
diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
index b4769e4..2905cda 100644
--- a/fs/xfs/Makefile
+++ b/fs/xfs/Makefile
@@ -94,6 +94,8 @@ xfs-y += xfs_alloc.o \
xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
+xfs-$(CONFIG_UML) += ../../lib/list_sort.o
+
# Objects in linux/
xfs-y += $(addprefix $(XFS_LINUX)/, \
kmem.o \
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: UML XFS link error list_sort
2010-03-07 2:28 UML XFS link error list_sort Parag Warudkar
@ 2010-03-07 3:25 ` Randy Dunlap
2010-03-07 10:07 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2010-03-07 3:25 UTC (permalink / raw)
To: Parag Warudkar; +Cc: linux-kernel, david
Parag Warudkar wrote:
> Hi Dave
>
> While building today's git for CONFIG_UML, I got a link error (list_sort
> undefined) for xfs.ko.
>
> Currently I am working around it with the below hack. Not sure the right
> thing to do would be some where at the arch level for UML or if the below
> would be appropriate.
>
> Parag
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index b4769e4..2905cda 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -94,6 +94,8 @@ xfs-y += xfs_alloc.o \
>
> xfs-$(CONFIG_XFS_TRACE) += xfs_btree_trace.o
>
> +xfs-$(CONFIG_UML) += ../../lib/list_sort.o
> +
> # Objects in linux/
> xfs-y += $(addprefix $(XFS_LINUX)/, \
> kmem.o \
> --
I posted a patch for xfs to select LIST_SORT (kconfig symbol)
so that the library is built for it (xfs).
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: UML XFS link error list_sort
2010-03-07 3:25 ` Randy Dunlap
@ 2010-03-07 10:07 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2010-03-07 10:07 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Parag Warudkar, linux-kernel, david, aelder
On Sat, Mar 06, 2010 at 07:25:10PM -0800, Randy Dunlap wrote:
> I posted a patch for xfs to select LIST_SORT (kconfig symbol)
> so that the library is built for it (xfs).
Can you just send it directly to Linus instead of waiting for the
next pull request?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-07 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-07 2:28 UML XFS link error list_sort Parag Warudkar
2010-03-07 3:25 ` Randy Dunlap
2010-03-07 10:07 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox