From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754819Ab0CGUcP (ORCPT ); Sun, 7 Mar 2010 15:32:15 -0500 Received: from mtagate5.uk.ibm.com ([194.196.100.165]:47542 "EHLO mtagate5.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754794Ab0CGUcO (ORCPT ); Sun, 7 Mar 2010 15:32:14 -0500 From: Christian Borntraeger Organization: IBM To: linux-ext4@vger.kernel.org Subject: [PATCH] ext4: allow defrag (EXT4_IOC_MOVE_EXT) in 32bit compat mode Date: Sun, 7 Mar 2010 21:32:10 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.33-self-05680-gb8fa057-dirty; KDE/4.3.4; x86_64; ; ) Cc: linux-kernel@vger.kernel.org, Akira Fujita MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201003072132.10579.borntraeger@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I have an x86_64 kernel with i386 userspace. e4defrag fails on the EXT4_IOC_MOVE_EXT ioctl because it is not wired up for the compat case. It seems that struct move_extent is compat save, only types with fixed widths are used: { __u32 reserved; /* should be zero */ __u32 donor_fd; /* donor file descriptor */ __u64 orig_start; /* logical start offset in block for orig */ __u64 donor_start; /* logical start offset in block for donor */ __u64 len; /* block length to be moved */ __u64 moved_len; /* moved block length */ }; Lets just wire up EXT4_IOC_MOVE_EXT for the compat case. Signed-off-by: Christian Borntraeger CCed: Akira Fujita --- fs/ext4/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -375,6 +375,8 @@ long ext4_compat_ioctl(struct file *file break; case EXT4_IOC_GROUP_ADD: break; + case EXT4_IOC_MOVE_EXT: + break; default: return -ENOIOCTLCMD; }